Repository navigation
Correct stale comments in vite configs, the relay sweep, test helpers, and the hosted README - #1125
Merged
Merged
Conversation
…, and the hosted README - lib/website vite configs: connect-port.ts is gone; Wall and useDorControl import dor-lib-common directly. - relay/src/app.ts: start.ts, not index.ts, owns the revocation sweep timer. - test-local-storage.ts: drop a list of localStorage-stubbing tests that had rotted (two named files never stub it). - WorkspaceTeardownModal.tsx: quit-confirm-store.ts imports terminal-registry, not quit.ts; the stories file lives under lib/src/stories. - tool-types.ts: ToolRender also includes playwright-screencast. - burrow-bounds.test.ts: remove a stacked duplicate JSDoc and an unused binding. - hosted/README.md: test:miniflare also runs the push-egress suite.
Deploying mouseterm with
|
| Latest commit: |
4b835ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://30cca4b6.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-nightly-survey-stale-com.mouseterm.pages.dev |
dormouse-bot
commented
Oct 14, 2026
dormouse-bot
left a comment
dormouse-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
The rewritten dor-lib-common alias comment in website/vite.config.ts now names two subpaths, but its last sentence still says the alias "covers both that subpath and the bare specifier".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment and doc fixes from tonight's survey. Each one pointed at a file, symbol, or behavior that no longer matches the code. There is no behavior change, and the only code edits are in a test file.
lib/vite.config.ts,lib/vite.pocket.config.ts,website/vite.config.ts: thedor-lib-commonalias comments citeconnect-port.ts, which no longer exists.Wall.tsxanduse-dor-control.tsimport the package'sbrowser-providersandbrowser-viewportssubpaths directly.relay/src/app.ts: the revocation-sweep doc saysindex.tsowns the timer. ThesetIntervalis inrelay/src/start.ts.lib/src/lib/test-local-storage.ts: the list of tests that stublocalStoragenameswindow-persistence.test.tsandremote/burrow/acl.test.ts, which never touch it, and leaves outpocket-client.test.ts. The list is dropped instead of corrected, because it would rot again.standalone/src/WorkspaceTeardownModal.tsx:quit-confirm-store.tsimports the terminal registry through the alias, notquit.ts. The stories file is atlib/src/stories/.lib/src/lib/platform/tool-types.ts: theToolRenderdoc leaves outplaywright-screencast, though the union includes it.lib/src/remote/burrow/burrow-bounds.test.ts: removes a leftover JSDoc stacked onconnectClientand an unusedotherbinding.hosted/README.md:test:miniflarealso runsrelay-push.test.ts.