Repository navigation
security-local: name every launch-flagged PTY write the OSC 367 audit reads - #1129
Merged
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
2e7bf5c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d2f970c3.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-security-local-launch-wr.mouseterm.pages.dev |
nedtwigg
had a problem deploying
to
hosted-preview
October 16, 2026 19:52 — with 
GitHub Actions
Error
GitHub Actions
Error
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OSC 367
FAIL IFindocs/specs/security-local.md→ "Terminal output" tells the auditor which writes may carrylaunch, but its list was wrong in two ways: it placedtypeToolCommandinlib/src/lib/terminal-lifecycle.ts(it lives inuse-dor-control.ts), and it left out the helper terminal's autorun write inwatchHelper. An auditor following the rule would look for the first in the wrong file and never be pointed at the third.The edit names all three
writePty(..., { launch: true })call sites inlib/src(grep -rn "launch: true" lib/src, non-test) with their actual paths. Docs-only, so no test;spec-lintpasses and the word count is within budget.