Repository navigation
Correct stale comments in the dor control server, Tauri routing, e2e harness headers, docs rail, and a Lath store test - #1130
Merged
Conversation
…harness headers, docs rail, and a Lath store test
Deploying mouseterm with
|
| Latest commit: |
04e0b0c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e9e14a92.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-nightly-stale-comments-1.mouseterm.pages.dev |
dormouse-bot
requested a deployment
to
hosted-preview
October 16, 2026 11:34 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only corrections from the nightly survey; no behavior changes. Each comment named a file, scope, or count that no longer matches the code:
standalone/sidecar/dor-control-server.js: the SHA-256 +timingSafeEqualpattern lives inrelay/src/secrets.ts, notrelay/src/state.ts. And a malformed request does not leave the connection open:writeResponseanswers withsocket.end(...), so every response, error or not, ends its connection (the client opens one per request).standalone/src-tauri/src/routing.rs:ARRIVAL_MAX's ordering rule points atCLOSE_WORKSPACE_TIMEOUT_MSindor/src/control-methods.ts, where it is defined and where the reverse pointer already lives, notdor/src/control-client.ts.relay/test/e2e-relay.test.mjs,remote-lib-common/test/harness/fake-client.mjs: both cited**Scope: e2e-client-burrow**under## Futureinremote-security-model.md. That scope is gone (onlyremote-trust-followupsremains), so they now point at the shipped "Noise suite" and relay.md "E2E framing" sections.lib/src/components/wall/lath-wall-store.test.ts: the comment said a Workspace switch reseeds the store;seeditself says Workspace switching does not seed. The reason the test holds is hydration reseeding a store with parked documents.website/src/components/DocsLayout.tsx,website/src/pages/Changelog.tsx,website/src/lib/docs-rail.test.tsx: page counts ("three of five", "four other pages", "seven pages … four different ways") predate the rail growing to nine pages inDOCS_PAGES; the comments now state the rule without a count.