Skip to content

Correct stale comments in the dor control server, Tauri routing, e2e harness headers, docs rail, and a Lath store test - #1130

Merged
nedtwigg merged 1 commit into
mainfrom
fix/nightly-stale-comments-1016
Oct 16, 2026
Merged

nedtwigg merged 1 commit into
mainfrom
fix/nightly-stale-comments-1016

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

Comment-only corrections from the nightly survey; no behavior changes. Each comment named a file, scope, or count that no longer matches the code:

  • standalone/sidecar/dor-control-server.js: the SHA-256 + timingSafeEqual pattern lives in relay/src/secrets.ts, not relay/src/state.ts. And a malformed request does not leave the connection open: writeResponse answers with socket.end(...), so every response, error or not, ends its connection (the client opens one per request).
  • standalone/src-tauri/src/routing.rs: ARRIVAL_MAX's ordering rule points at CLOSE_WORKSPACE_TIMEOUT_MS in dor/src/control-methods.ts, where it is defined and where the reverse pointer already lives, not dor/src/control-client.ts.
  • relay/test/e2e-relay.test.mjs, remote-lib-common/test/harness/fake-client.mjs: both cited **Scope: e2e-client-burrow** under ## Future in remote-security-model.md. That scope is gone (only remote-trust-followups remains), so they now point at the shipped "Noise suite" and relay.md "E2E framing" sections.
  • lib/src/components/wall/lath-wall-store.test.ts: the comment said a Workspace switch reseeds the store; seed itself says Workspace switching does not seed. The reason the test holds is hydration reseeding a store with parked documents.
  • website/src/components/DocsLayout.tsx, website/src/pages/Changelog.tsx, website/src/lib/docs-rail.test.tsx: page counts ("three of five", "four other pages", "seven pages … four different ways") predate the rail growing to nine pages in DOCS_PAGES; the comments now state the rule without a count.

…harness headers, docs rail, and a Lath store test
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 04e0b0c
Status: ✅  Deploy successful!
Preview URL: https://e9e14a92.mouseterm.pages.dev
Branch Preview URL: https://fix-nightly-stale-comments-1.mouseterm.pages.dev

View logs

@nedtwigg
nedtwigg merged commit 052e5ce into main Oct 16, 2026
16 of 17 checks passed
@nedtwigg
nedtwigg deleted the fix/nightly-stale-comments-1016 branch October 16, 2026 20:26

This branch is waiting to be deployed

1 waiting deployment
hosted-preview — 04e0b0cf Waiting Oct 16, 2026 by dormouse-bot via deploy #1363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants