Skip to content

feat: support nanoparticle pdf refinement - #33

Merged
sbillinge merged 3 commits into
diffpy:mainfrom
ycexiao:nanoparticle
Sep 26, 2026
Merged

sbillinge merged 3 commits into
diffpy:mainfrom
ycexiao:nanoparticle

Conversation

@ycexiao

@ycexiao ycexiao commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR address?

Add diffpy.apps interface to solve the example case diffpy.srfit/docs/example/nppdfcrystal.py

What should the reviewer(s) do?

@codecov

codecov Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.03%. Comparing base (76ca2b3) to head (62630c0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   97.43%   98.03%   +0.59%     
==========================================
  Files           8        8              
  Lines         429      559     +130     
==========================================
+ Hits          418      548     +130     
  Misses         11       11              
Files with missing lines Coverage Δ
tests/helper.py 98.94% <100.00%> (+0.19%) ⬆️
tests/test_parametric_model.py 100.00% <100.00%> (ø)
tests/test_refinement_server.py 100.00% <100.00%> (ø)
tests/test_refinement_session.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ycexiao
ycexiao marked this pull request as ready for review September 19, 2026 18:31
@ycexiao

ycexiao commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge it's ready for review.

@ycexiao

ycexiao commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge, it's ready to merge.

@sbillinge
sbillinge merged commit 6320b90 into diffpy:main Sep 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants