Skip to content

chore: remove customPQConfig and deprecate NoMetaStructureAdapter - #55

Merged
sbillinge merged 1 commit into
diffpy:mainfrom
SYMSCAE:pq-removal
Nov 1, 2026
Merged

sbillinge merged 1 commit into
diffpy:mainfrom
SYMSCAE:pq-removal

Conversation

@SYMSCAE

@SYMSCAE SYMSCAE commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

This PR removes customPQConfig and deprecates NoMetaStructureAdapter as mentioned in #5. GIL and performance investigations are not done, should put it in scope of further releases.

@sbillinge

Copy link
Copy Markdown
Contributor

@SYMSCAE please can you make an issue for the GIL and performance investigations with enough info that we can return to it later. I will attach it to a future release. When that is done I can merge this. Please can you post the result of running tests here too as they are not running in CI yet.

@SYMSCAE

SYMSCAE commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge I've created the issue, please see if there's more info needed. Here's the testing results and this PR needs to be merged with diffpy/diffpy.srreal#100.

libdiffpy's own cpp tests:
/home/dev/dbs/diffpy.srreal/build/nopq/libdiffpy/build/develop-x86_64/tests/alltests Running cxxtest tests (175 tests)...............................................................................................................................................................................OK! scons: done building targets.

srreal's tests:
429 passed, 423 warnings in 1.70s

@sbillinge
sbillinge merged commit e8292b5 into diffpy:main Nov 1, 2026
@SYMSCAE
SYMSCAE deleted the pq-removal branch November 3, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants