Add method GetRwHistory to lsq - #107
Merged
Merged
Conversation
Contributor
|
LGTM Can merge when it is passing tests. btw @clemisch it has picked up a conflict along the way. |
turns internal std::vector<REAL> into Python list
Contributor
Author
|
Thanks Simon, I fixed the conflict. I think the tests will work only after objcryst has a new release? |
Contributor
|
@clemisch please ping me to merge this when objcryst goes out and this passes. |
Contributor
Author
|
@sbillinge I bumped libobjcryst to 2026.3.0 and tests pass 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes new Rw history in LSQ object to Python via
lsq.GetRwHistory().Requires vincefn/objcryst#90 .
Rw history is stored in internal vector over one call of
lsq.Refine(). It's in "fractional" units ∈ [0, 1], not in percent. That's just because objcryst seems to handle mostly fractional Rw internally. We could change the user-facing value to Rwp.