docs: document unified memory env configuration - #1051
Open
amarkdotdev wants to merge 3 commits into
Open
Conversation
Fixes docker#994 Signed-off-by: Aaron <amark@g.jct.ac.il>
Fixes docker#994 Signed-off-by: Aaron <amark@g.jct.ac.il>
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/unified-memory.md" line_range="20" />
<code_context>
+## docker model run
+
+```shell
+docker model run -e GGML_CUDA_ENABLE_UNIFIED_MEMORY=1 ai/gemma3 "Hello"
+```
+
</code_context>
<issue_to_address>
**issue (bug_risk):** The documented `docker model run -e GGML_CUDA_ENABLE_UNIFIED_MEMORY=1 ...` command fails because this repository's `run` command does not define an `-e`/`--env` flag, so Cobra rejects the option instead of configuring the runner.
**Triggers:** When users follow the Docker Model Runner CLI example.
**Suggested fix:** Set the variable in the environment before invoking `docker model run`, or document a supported runner/container configuration mechanism instead of passing `-e` to `docker model run`.
```suggestion
GGML_CUDA_ENABLE_UNIFIED_MEMORY=1 docker model run ai/gemma3 "Hello"
```
</issue_to_address>
### Comment 2
<location path="docs/unified-memory.md" line_range="1" />
<code_context>
+# Unified memory configuration for integrated GPUs
+
+Docker Model Runner uses llama.cpp under the hood. On systems with integrated GPUs (for example AMD APUs), available shared memory may be reported incorrectly unless unified memory is enabled.
</code_context>
<issue_to_address>
**nitpick:** The new unified-memory document is not linked from `README.md` or any existing documentation index, so the repository's stated README-link verification is false and users browsing the README cannot discover this configuration guide.
**Suggested fix:** Add a README link to `docs/unified-memory.md`, preferably alongside the existing documentation resources.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Use env-prefix syntax for docker model run instead of invalid -e flag. Add unified-memory.md to README Additional Resources. Signed-off-by: Aaron <amark@g.jct.ac.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #994
Test plan