Repository navigation
Reduce fixed allocations in middleware pipeline terminal paths - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Middleware dispatch creates continuation closures even when no matching middleware remains. Split terminal dispatch from the methods that capture continuation state, and remove the terminal context object used only to read back the supplied cancellation token.
Activity tracking, continuation validation, cancellation propagation, and disposal behavior remain in place. This is a small allocation optimization; it does not remove the per-layer ownership wrappers responsible for most of the regression against 1.0.0.
BenchmarkDotNet 0.15.8 on .NET 10.0.13 measured about 128 fewer bytes per operation with middleware:
Timing measurements were noisy, so no latency improvement is claimed.
Validation: