Add Router::pushGlobalMiddleware() so launchers can register global middleware - #337
Merged
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Since 4.x the Router builds each request's global middleware chain from
Gateway::getGlobalMiddleware(). It never runsGateway::handle(). Packages that register global middleware the old way, by callingapplyMiddleware()on the gateway, therefore have no effect. That call only changes the gateway's own$startclosure, which nothing executes.Found through
doppar/insight. Its launcher registered its profiler middleware this way, so with the line removed fromApp\Http\Gateway::$middlewarethe toolbar never appeared. Keeping the line in Gateway made the toolbar impossible to turn off, because the middleware ran even when the package was disabled. The failure is silent, with no error.Change
Phaseolies\Support\Router:
Pushed middleware is applied after the Gateway's own global middleware, so it wraps them, like the last entry in
Gateway::$middleware. GatewayInterface is unchanged, so existing Gateway implementations keep working with no edits. Apps that don't push anything see no change in behavior.Checklist