Skip to content

remove ErrorHistoryRecorder class from skeleton by adding it in framework - #338

Merged
techmahedy merged 1 commit into
doppar:4.xfrom
techmahedy:techmahedy-4.x
Sep 25, 2026
Merged

techmahedy merged 1 commit into
doppar:4.xfrom
techmahedy:techmahedy-4.x

Conversation

@techmahedy

@techmahedy techmahedy commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

…work:

Pull Request Checklist

Q A
Branch? 4.x
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Description

If we add this logic to the setExceptionError method in the Response class, we won’t need to set it manually in the skeleton project’s App\Http\Exceptions\BeforeExceptionHandler::handle method.

if (class_exists($class = \Doppar\Insight\Support\ErrorHistoryRecorder::class)) {
    app($class)->record($exception);
}

Checklist

  • Tests have been added or updated
  • Documentation has been updated if necessary
  • Code follows the project coding standards
  • All tests pass locally

@techmahedy
techmahedy merged commit 20a06dc into doppar:4.x Sep 25, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant