Skip to content

Fix Paginator prev/next links leaking merged request input into URLs - #339

Merged
techmahedy merged 1 commit into
doppar:4.xfrom
techmahedy:techmahedy-4.x
Sep 25, 2026
Merged

techmahedy merged 1 commit into
doppar:4.xfrom
techmahedy:techmahedy-4.x

Conversation

@techmahedy

@techmahedy techmahedy commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Pull Request Checklist

Q A
Branch? 4.x
Bug fix? yes
New feature? no
Deprecations? no
Issues Yes
License MIT

Description

Paginator builds its links from two different sources:

  • url($page), which backs the page-number links and the Jump dropdown, reads request()->query(), the real query string.
  • previousPageUrl() and nextPageUrl() read request()->except('page'), which is the request's whole input bag.

Real query-string filters such as ?search=foo are still carried into the links. Only server-side merged input is excluded.

Checklist

  • Tests have been added or updated
  • Documentation has been updated if necessary
  • Code follows the project coding standards
  • All tests pass locally

@techmahedy
techmahedy merged commit 5419273 into doppar:4.x Sep 25, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant