Skip to content

fix(cli-release): make dry-run actually dry and always clean up #37587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wezell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli-release): make dry-run actually dry and always clean up #37587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/cicd_release-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,14 @@ jobs:
env:
JRELEASER_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
JRELEASER_PROJECT_VERSION: ${{ needs.precheck.outputs.RELEASE_VERSION }}
JRELEASER_DRY_RUN: ${{ github.event.inputs.dry-run || 'false' }}
with:
cleanup-runner: true
github-token: ${{ secrets.GITHUB_TOKEN }}
stage-name: "JReleaser"
maven-args: "-Prelease validate -DartifactsDir=artifacts -Dm2Dir=$HOME/.m2/repository -Djreleaser.git.root.search=true -pl :dotcms-cli-parent -Dmaven.plugin.validation=VERBOSE"
# The plugin's dry-run is the Maven property jreleaser.dry.run (it does not
# read JRELEASER_DRY_RUN), so set it explicitly; otherwise a dry-run
# dispatch would create a real GitHub release.
maven-args: "-Prelease validate -DartifactsDir=artifacts -Dm2Dir=$HOME/.m2/repository -Djreleaser.git.root.search=true -pl :dotcms-cli-parent -Dmaven.plugin.validation=VERBOSE ${{ github.event.inputs.dry-run == 'true' && '-Djreleaser.dry.run=true' || '' }}"
artifacts-from: ${{ env.ARTIFACT_RUN_ID }}
version: ${{ needs.precheck.outputs.RELEASE_VERSION }}

Expand Down Expand Up @@ -229,7 +231,8 @@ jobs:
# Publish NPM package
publish-npm-package:
name: "Publish NPM Package"
if: success() # Run only if explicitly indicated and successful
# Never publish on a dry-run dispatch (this job runs `npm publish` for real).
if: success() && github.event.inputs.dry-run != 'true'
needs: [ precheck, build, build-cli, release ]
runs-on: ubuntu-${{ vars.UBUNTU_RUNNER_VERSION || '24.04' }}
steps:
Expand Down Expand Up @@ -395,7 +398,9 @@ jobs:
# Clean up temporary branches
clean-up:
name: "Clean Up"
if: ${{ needs.precheck.outputs.AUXILIARY_BRANCH != '' }}
# always(): the auxiliary branch must be deleted even when an earlier job is
# skipped (e.g. publish-npm-package on a dry-run) or has failed.
if: ${{ always() && needs.precheck.outputs.AUXILIARY_BRANCH != '' }}
needs: [ precheck, build, build-cli, release, publish-npm-package ]
runs-on: ubuntu-${{ vars.UBUNTU_RUNNER_VERSION || '24.04' }}
steps:
Expand Down
Loading