Issue #12: Drop PHP 8.2, fix attribute/dot-notation resolution bugs, expand docs - #13
Merged
Merged
Conversation
…expand docs Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
…expand docs Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.0 #13 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 39 44 +5
===========================================
Files 6 7 +1
Lines 84 99 +15
===========================================
+ Hits 84 99 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…expand docs Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Member
Author
|
@arhimede Note that this targets a new |
…expand docs Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
arhimede
approved these changes
Sep 16, 2026
Member
|
Make a new release then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
composer.jsonrequires~8.3.0 || ~8.4.0 || ~8.5.0; removed from both CI matricesFixed
AttributedServiceFactorytreated a config value ofnullas a missing key (isset()→array_key_exists()/offsetExists())$originalKeyproperty — shared factory instances made it statefulAttributedRepositoryFactoryreturned whatever Doctrine built, so an entity missingrepositoryClassproduced a repository of the wrong type under the requested service name#[Entity]attribute naming a non-existent classfindEntityAttribute()/findInjectAttribute()returnedobjectwhere?Entity/?Injectwas declared (IDE + static-analysis error)Changed
#[Entity]→TARGET_CLASS,#[Inject]→TARGET_METHOD(wereTARGET_ALL, where misplacement was a silent no-op)InvalidArgumentException::missingKey()andRuntimeException::unexpectedRepository()getAttributes(X::class);Entity::$nameis now a promotedreadonlypropertyignoreErrorsentries fromphpstan.neonby fixing their causeTests
ArrayAccesstraversal, exact-name service preferred over dot resolution, unregistered class instantiated directly, missing entity, wrong repository classDocumentation
#[Inject], config values, repositories, performance, testingInvalidArgumentException, constructor-less classes, the unregistered-class fallback,ArrayAccesstraversal, only-direct-recursion detection, therepositoryClassrequirement,createObject()vs__invoke()usestatements) and theSrevicetyposBC notes
readKeysFromArray()gained a third parameter (string $serviceKey) — overriding subclasses must be updated, andbackwardCompatibilityCheckwill flag it