Document crypto spec default values - #415
Open
jonathanpeppers wants to merge 2 commits into
Open
Conversation
Refs #302 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 14, 2026 08:10
jonathanpeppers
enabled auto-merge (squash)
August 14, 2026 08:10
There was a problem hiding this comment.
Pull request overview
Updates Xamarin/Mono.Android XML documentation for two javax.crypto.spec default constants to replace To be added. placeholders, aligning the generated .NET API docs more closely with Android reference documentation and reducing the placeholder count tracked by #302.
Changes:
- Documented the
<value>text forJavax.Crypto.Spec.PSource.PSpecified.Default. - Documented the
<value>text forJavax.Crypto.Spec.OAEPParameterSpec.Default.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/xml/Javax.Crypto.Spec/PSource+PSpecified.xml | Replaces the placeholder <value> for PSource.PSpecified.Default with a concrete description. |
| docs/xml/Javax.Crypto.Spec/OAEPParameterSpec.xml | Replaces the placeholder <value> for OAEPParameterSpec.Default (currently duplicative of summary/remarks). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #302 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and removed request for
dalexsoto
August 14, 2026 08:21
Member
Author
|
@dalexsoto review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
valuetext forOAEPParameterSpec.DefaultandPSource.PSpecified.Default.Refs #302and leaves the issue open.Sources
Validation
docs/xml/Javax.Crypto.Spec/*.xmlfiles as XML.git diff --check.To be addedplaceholders remain; neither documented Java-level constant remains a placeholder.Refs #302