Document TextUtils string splitter iteration - #418
Open
jonathanpeppers wants to merge 2 commits into
Open
Conversation
Refs #223 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 14, 2026 08:12
jonathanpeppers
enabled auto-merge (squash)
August 14, 2026 08:12
There was a problem hiding this comment.
Pull request overview
This PR updates the XML documentation for Android.Text.TextUtils.SimpleStringSplitter iteration-related members to replace To be added. placeholders with concrete return/value contracts.
Changes:
- Documented the
HasNextproperty value contract (true/falsemeaning). - Replaced placeholder return docs for
Iterator()and bothNextbindings with specific return descriptions.
Suppressed comments (2)
docs/xml/Android.Text/TextUtils+SimpleStringSplitter.xml:211
Iterator.next()is specified to throwNoSuchElementExceptionwhen there are no more elements. This binding doc omits the exception contract; adding it aligns with the standardjava.util.Iterator.next()contract and other iterator docs in this repo.
This issue also appears on line 269 of the same file.
<returns>The next element in the iteration.</returns>
<remarks>
<para>Portions of this page are modifications based on work created and shared by the <format type="text/html"><a href="https://developers.google.com/terms/site-policies" title="Android Open Source Project">Android Open Source Project</a></format> and used according to terms described in the <format type="text/html"><a href="https://creativecommons.org/licenses/by/2.5/" title="Creative Commons 2.5 Attribution License">Creative Commons 2.5 Attribution License.</a></format></para>
</remarks>
</Docs>
docs/xml/Android.Text/TextUtils+SimpleStringSplitter.xml:273
next()is specified to throwNoSuchElementExceptionwhen called after iteration is exhausted. This doc update improves the return contract but still omits the exception contract; add it to match thejava.util.Iterator.next()contract and other iterator docs in this repo.
<returns>The next element in the iteration.</returns>
<remarks>
<para>Portions of this page are modifications based on work created and shared by the <format type="text/html"><a href="https://developers.google.com/terms/site-policies" title="Android Open Source Project">Android Open Source Project</a></format> and used according to terms described in the <format type="text/html"><a href="https://creativecommons.org/licenses/by/2.5/" title="Creative Commons 2.5 Attribution License">Creative Commons 2.5 Attribution License.</a></format></para>
</remarks>
<since version="Added in API level 1" />
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #223 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@dalexsoto review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #223
Summary
TextUtils.SimpleStringSplitteriteration members:HasNext,Iterator, and bothNextbindings.Iterator()returns the splitter instance itself because it is its own iterator.JniPeerMembersbinding-infrastructure placeholders and the rest ofAndroid.Textout of scope.To be added.placeholders remain inAndroid.TextXML documentation.Sources
SimpleStringSplitter.iterator()implementation; used for the instance-identity detail absent from the Android reference page)Validation
docs/xml/Android.Text/TextUtils+SimpleStringSplitter.xmlwith PowerShell[xml].git diff --checkand reviewed the complete diff after each change.