Document NIO channel socket addresses - #419
Open
jonathanpeppers wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 14, 2026 08:12
jonathanpeppers
enabled auto-merge (squash)
August 14, 2026 08:13
There was a problem hiding this comment.
Pull request overview
Updates the generated XML API documentation for Java.Nio.Channels to describe the local/remote socket-address properties on key NIO channel types, aligning the Xamarin/MonoAndroid docs with the Android reference behavior.
Changes:
- Documented
LocalAddressonSocketChannel,ServerSocketChannel, andDatagramChannel. - Documented
RemoteAddressonSocketChannelandDatagramChannel. - Added direct links to the corresponding Android reference documentation pages in each updated member’s remarks.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/xml/Java.Nio.Channels/SocketChannel.xml | Replaced placeholders for LocalAddress/RemoteAddress with real summaries/values and added Android reference links. |
| docs/xml/Java.Nio.Channels/ServerSocketChannel.xml | Replaced placeholder for LocalAddress with bound-address documentation and added Android reference link. |
| docs/xml/Java.Nio.Channels/DatagramChannel.xml | Replaced placeholders for LocalAddress/RemoteAddress with real summaries/values and added Android reference links. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@dalexsoto review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatagramChannelandSocketChannel, plus the local socket-address property onServerSocketChannel.To be addedplaceholders.Sources
Validation
[xml]cast.git diff --check.docs/xml/index.xmlis unchanged.Refs #214