Document DocumentBuilder namespace awareness - #422
Closed
jonathanpeppers wants to merge 0 commit into
Closed
Conversation
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 14, 2026 08:33
jonathanpeppers
enabled auto-merge (squash)
August 14, 2026 08:33
There was a problem hiding this comment.
Pull request overview
This PR updates the XML documentation for Javax.Xml.Parsers.DocumentBuilder.IsNamespaceAware to replace the placeholder <value> text with the official return contract, aligning the docs with the Android/Java reference behavior while leaving the remaining namespace placeholders intact.
Changes:
- Replaced the
To be added.placeholder inDocumentBuilder.IsNamespaceAwarewith a concrete<c>true</c>/<c>false</c>return contract. - Kept the update narrowly scoped to a single property/value doc entry (consistent with the PR description’s intent).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@dalexsoto review |
auto-merge was automatically disabled
August 14, 2026 16:56
Pull request was closed
jonathanpeppers
force-pushed
the
jonathanpeppers-document-javax-xml-parsers-4cd
branch
from
August 14, 2026 16:56
bf8845d to
dbb24b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #280
Adds official return contracts for
DocumentBuilder.IsNamespaceAwareandDocumentBuilder.IsValidating. The namespace retains 79 scoped placeholders, so this deliberately narrow change does not close the issue.Sources
Validation
docs/xml/Javax.Xml.Parsers/DocumentBuilder.xmlas XML.git diff --checkand inspected the focused two-member diff.