Skip to content

Document Android transition modes - #423

Open
jonathanpeppers wants to merge 3 commits into
mainfrom
jonathanpeppers-document-android-transitions-apis
Open

Document Android transition modes#423
jonathanpeppers wants to merge 3 commits into
mainfrom
jonathanpeppers-document-android-transitions-apis

Conversation

@jonathanpeppers

@jonathanpeppers jonathanpeppers commented Aug 14, 2026

Copy link
Copy Markdown
Member

Summary

  • Document FadingMode, VisibilityMode, TransitionOrdering, and MatchTarget, including all ten enum values.
  • Link Android reference documentation for each enum type and explicit AOSP source attribution for matching-constant details absent from the public reference.

Sources

Validation

  • Parsed all four changed XML files with System.Xml.XmlReader.
  • Confirmed CRLF line endings and no remaining To be added placeholders in the changed files.
  • Ran git diff --check origin/main...HEAD.

Refs #212

Refs #212

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the generated XML documentation for Android.Transitions by replacing placeholder text with meaningful descriptions for three transition-related enum types and their values, and by adding links to the official Android reference docs that define their behavior.

Changes:

  • Updated type-level <summary> docs for FadingMode, VisibilityMode, and TransitionOrdering.
  • Replaced To be added. placeholders with concrete value descriptions for all six enum members.
  • Added per-type remarks linking to the corresponding Android Java reference pages.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docs/xml/Android.Transitions/FadingMode.xml Adds proper enum and member summaries plus a link to the Android Fade reference.
docs/xml/Android.Transitions/VisibilityMode.xml Adds proper enum and member summaries plus a link to the Android Visibility reference.
docs/xml/Android.Transitions/TransitionOrdering.xml Adds proper enum and member summaries plus a link to the Android TransitionSet reference.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Refs #212

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
auto-merge was automatically disabled August 14, 2026 10:07

Pull Request is not mergeable

Refs #212

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers
jonathanpeppers enabled auto-merge (squash) August 14, 2026 10:15
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants