Document HTTP parameter contracts - #426
Open
jonathanpeppers wants to merge 2 commits into
Open
Conversation
Refs #283 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 14, 2026 09:06
jonathanpeppers
enabled auto-merge (squash)
August 14, 2026 09:06
There was a problem hiding this comment.
Pull request overview
This PR updates the generated XML documentation for Org.Apache.Http.Params to replace “To be added.” placeholders with concrete parameter/return contracts, aligning the docs more closely with the upstream Apache HttpComponents semantics.
Changes:
- Updated multiple member
<Docs>blocks to provide real<summary>,<param>, and<returns>content for key parameter APIs. - Improved return/value descriptions for several parameter lookup helpers (e.g., boolean true/false semantics).
- Reduced placeholder text in the namespace docs to address Issue #283.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/xml/Org.Apache.Http.Params/BasicHttpParams.xml | Fills in docs for common parameter operations (copy/get/is-set/remove/set). |
| docs/xml/Org.Apache.Http.Params/AbstractHttpParams.xml | Improves documentation for typed parameter getters and boolean helper semantics. |
Suppressed comments (4)
docs/xml/Org.Apache.Http.Params/BasicHttpParams.xml:362
- The method summary/params were filled in, but the return contract is still left as "To be added.". For HttpParams.setParameter this is a fluent API that returns the updated parameter set (typically this instance).
<summary>Assigns the value to the parameter with the given name.</summary>
<returns>To be added.</returns>
docs/xml/Org.Apache.Http.Params/AbstractHttpParams.xml:250
- The return type is
int, but the docs describe returningJava.Lang.Integerand don't mention the defaultValue behavior. Also, "parent name" should be "parameter name".
<param name="name">the parent name.</param>
<param name="defaultValue">the default value.</param>
<summary>Returns an <see cref="T:Java.Lang.Integer" /> parameter value with the given name.</summary>
<returns>an <see cref="T:Java.Lang.Integer" /> that represents the value of the parameter.</returns>
docs/xml/Org.Apache.Http.Params/AbstractHttpParams.xml:213
- The return type is
double, but the docs describe returningJava.Lang.Doubleand don't mention the defaultValue behavior. Also, "parent name" should be "parameter name".
<param name="name">the parent name.</param>
<param name="defaultValue">the default value.</param>
<summary>Returns a <see cref="T:Java.Lang.Double" /> parameter value with the given name.</summary>
<returns>a <see cref="T:Java.Lang.Double" /> that represents the value of the parameter.</returns>
docs/xml/Org.Apache.Http.Params/AbstractHttpParams.xml:287
- The return type is
long, but the docs describe returningJava.Lang.Longand don't mention the defaultValue behavior. Also, "parent name" should be "parameter name".
<param name="name">the parent name.</param>
<param name="defaultValue">the default value.</param>
<summary>Returns a <see cref="T:Java.Lang.Long" /> parameter value with the given name.</summary>
<returns>a <see cref="T:Java.Lang.Long" /> that represents the value of the parameter.</returns>
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #283 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #283
Sources
AbstractHttpParams.java: https://raw.githubusercontent.com/apache/httpcomponents-core/rel/v4.0/module-main/src/main/java/org/apache/http/params/AbstractHttpParams.javaBasicHttpParams.java: https://raw.githubusercontent.com/apache/httpcomponents-core/rel/v4.0/module-main/src/main/java/org/apache/http/params/BasicHttpParams.javaHttpParams.java: https://raw.githubusercontent.com/apache/httpcomponents-core/rel/v4.0/module-main/src/main/java/org/apache/http/params/HttpParams.javaValidation
git diff --check.