Skip to content

Document HTTP parameter contracts - #426

Open
jonathanpeppers wants to merge 2 commits into
mainfrom
jonathanpeppers-document-apache-http-params
Open

Document HTTP parameter contracts#426
jonathanpeppers wants to merge 2 commits into
mainfrom
jonathanpeppers-document-apache-http-params

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Refs #283

Sources

Validation

  • Parsed both modified XML files with PowerShell's XML parser.
  • Ran git diff --check.
  • Verified CRLF line endings with no bare LF in both modified files.

Refs #283

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the generated XML documentation for Org.Apache.Http.Params to replace “To be added.” placeholders with concrete parameter/return contracts, aligning the docs more closely with the upstream Apache HttpComponents semantics.

Changes:

  • Updated multiple member <Docs> blocks to provide real <summary>, <param>, and <returns> content for key parameter APIs.
  • Improved return/value descriptions for several parameter lookup helpers (e.g., boolean true/false semantics).
  • Reduced placeholder text in the namespace docs to address Issue #283.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/xml/Org.Apache.Http.Params/BasicHttpParams.xml Fills in docs for common parameter operations (copy/get/is-set/remove/set).
docs/xml/Org.Apache.Http.Params/AbstractHttpParams.xml Improves documentation for typed parameter getters and boolean helper semantics.
Suppressed comments (4)

docs/xml/Org.Apache.Http.Params/BasicHttpParams.xml:362

  • The method summary/params were filled in, but the return contract is still left as "To be added.". For HttpParams.setParameter this is a fluent API that returns the updated parameter set (typically this instance).
        <summary>Assigns the value to the parameter with the given name.</summary>
        <returns>To be added.</returns>

docs/xml/Org.Apache.Http.Params/AbstractHttpParams.xml:250

  • The return type is int, but the docs describe returning Java.Lang.Integer and don't mention the defaultValue behavior. Also, "parent name" should be "parameter name".
        <param name="name">the parent name.</param>
        <param name="defaultValue">the default value.</param>
        <summary>Returns an <see cref="T:Java.Lang.Integer" /> parameter value with the given name.</summary>
        <returns>an <see cref="T:Java.Lang.Integer" /> that represents the value of the parameter.</returns>

docs/xml/Org.Apache.Http.Params/AbstractHttpParams.xml:213

  • The return type is double, but the docs describe returning Java.Lang.Double and don't mention the defaultValue behavior. Also, "parent name" should be "parameter name".
        <param name="name">the parent name.</param>
        <param name="defaultValue">the default value.</param>
        <summary>Returns a <see cref="T:Java.Lang.Double" /> parameter value with the given name.</summary>
        <returns>a <see cref="T:Java.Lang.Double" /> that represents the value of the parameter.</returns>

docs/xml/Org.Apache.Http.Params/AbstractHttpParams.xml:287

  • The return type is long, but the docs describe returning Java.Lang.Long and don't mention the defaultValue behavior. Also, "parent name" should be "parameter name".
        <param name="name">the parent name.</param>
        <param name="defaultValue">the default value.</param>
        <summary>Returns a <see cref="T:Java.Lang.Long" /> parameter value with the given name.</summary>
        <returns>a <see cref="T:Java.Lang.Long" /> that represents the value of the parameter.</returns>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/xml/Org.Apache.Http.Params/BasicHttpParams.xml Outdated
Comment thread docs/xml/Org.Apache.Http.Params/AbstractHttpParams.xml Outdated
Refs #283

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants