Skip to content

Document Android.Views.Autofill public API - #435

Merged
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-document-android-autofill
Aug 14, 2026
Merged

Document Android.Views.Autofill public API#435
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-document-android-autofill

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Sources

Validation

  • Parsed every modified XML document.
  • Verified CRLF line endings in every modified document.
  • Ran git diff --check.

Refs #222

This deliberately documents only entries covered by Android's authoritative API reference. The remaining scoped placeholders are generated JNI/threshold members, compatibility wrapper types, or constructors without an authoritative narrative description.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the generated XML documentation for the Android.Views.Autofill public API surface by replacing “To be added.” placeholders with concise, authoritative summaries/returns/values aligned with Android’s reference documentation (Refs #222).

Changes:

  • Filled in missing <summary>, <value>, <returns>, and <param> documentation across key Autofill types (AutofillManager, AutofillId, AutofillValue, VirtualViewFillInfo, etc.).
  • Added clearer descriptions for Parcelable-related members (for example, CREATOR, DescribeContents, WriteToParcel).
  • Documented Autofill UI event semantics via AutofillEventType and callback parameter descriptions.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
docs/xml/Android.Views.Autofill/VirtualViewFillInfo+Builder.xml Documents builder return values and autofill-hints setter semantics.
docs/xml/Android.Views.Autofill/VirtualViewFillInfo.xml Documents autofill-hints property return/value text.
docs/xml/Android.Views.Autofill/AutofillValue.xml Replaces placeholders for creator/parcelable members and typed autofill value APIs.
docs/xml/Android.Views.Autofill/AutofillManager+AutofillCallback.xml Documents event parameter meaning for autofill state changes.
docs/xml/Android.Views.Autofill/AutofillManager.xml Documents various AutofillManager property values (including nullability/booleans).
docs/xml/Android.Views.Autofill/AutofillId.xml Documents parcelable members and boolean/property values for AutofillId.
docs/xml/Android.Views.Autofill/AutofillEventType.xml Adds enum-level and member-level descriptions for autofill UI event reporting.
Suppressed comments (1)

docs/xml/Android.Views.Autofill/AutofillValue.xml:818

  • Spelling inconsistency: this member summary/remarks use "toggable" while the value text uses "toggleable". Align to the correct spelling "toggleable".
        <summary>Gets the value to autofill a toggable field.</summary>
        <value>The value used to autofill a toggleable field.</value>
        <remarks>
          <para>Gets the value to autofill a toggable field.</para>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/xml/Android.Views.Autofill/AutofillId.xml Outdated
Comment thread docs/xml/Android.Views.Autofill/AutofillValue.xml Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers
jonathanpeppers requested review from dalexsoto and removed request for dalexsoto August 14, 2026 11:03
@jonathanpeppers
jonathanpeppers enabled auto-merge (squash) August 14, 2026 11:03
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

1 similar comment
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Autofill API contracts are documented accurately, and the prior grammar and terminology findings are fixed.

@jonathanpeppers
jonathanpeppers merged commit c11c057 into main Aug 14, 2026
3 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-document-android-autofill branch August 14, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants