Document Android.Views.Autofill public API - #435
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 14, 2026 10:52
jonathanpeppers
enabled auto-merge (squash)
August 14, 2026 10:52
There was a problem hiding this comment.
Pull request overview
This PR improves the generated XML documentation for the Android.Views.Autofill public API surface by replacing “To be added.” placeholders with concise, authoritative summaries/returns/values aligned with Android’s reference documentation (Refs #222).
Changes:
- Filled in missing
<summary>,<value>,<returns>, and<param>documentation across key Autofill types (AutofillManager,AutofillId,AutofillValue,VirtualViewFillInfo, etc.). - Added clearer descriptions for Parcelable-related members (for example,
CREATOR,DescribeContents,WriteToParcel). - Documented Autofill UI event semantics via
AutofillEventTypeand callback parameter descriptions.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/xml/Android.Views.Autofill/VirtualViewFillInfo+Builder.xml | Documents builder return values and autofill-hints setter semantics. |
| docs/xml/Android.Views.Autofill/VirtualViewFillInfo.xml | Documents autofill-hints property return/value text. |
| docs/xml/Android.Views.Autofill/AutofillValue.xml | Replaces placeholders for creator/parcelable members and typed autofill value APIs. |
| docs/xml/Android.Views.Autofill/AutofillManager+AutofillCallback.xml | Documents event parameter meaning for autofill state changes. |
| docs/xml/Android.Views.Autofill/AutofillManager.xml | Documents various AutofillManager property values (including nullability/booleans). |
| docs/xml/Android.Views.Autofill/AutofillId.xml | Documents parcelable members and boolean/property values for AutofillId. |
| docs/xml/Android.Views.Autofill/AutofillEventType.xml | Adds enum-level and member-level descriptions for autofill UI event reporting. |
Suppressed comments (1)
docs/xml/Android.Views.Autofill/AutofillValue.xml:818
- Spelling inconsistency: this member summary/remarks use "toggable" while the value text uses "toggleable". Align to the correct spelling "toggleable".
<summary>Gets the value to autofill a toggable field.</summary>
<value>The value used to autofill a toggleable field.</value>
<remarks>
<para>Gets the value to autofill a toggable field.</para>
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jonathanpeppers
disabled auto-merge
August 14, 2026 11:03
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and removed request for
dalexsoto
August 14, 2026 11:03
jonathanpeppers
enabled auto-merge (squash)
August 14, 2026 11:03
Member
Author
|
@dalexsoto review |
1 similar comment
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Aug 14, 2026
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The Autofill API contracts are documented accurately, and the prior grammar and terminology findings are fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sources
Validation
git diff --check.Refs #222
This deliberately documents only entries covered by Android's authoritative API reference. The remaining scoped placeholders are generated JNI/threshold members, compatibility wrapper types, or constructors without an authoritative narrative description.