Skip to content

Document Java.Awt.Font - #437

Merged
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-document-java-awt-font
Aug 15, 2026
Merged

Document Java.Awt.Font#437
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-document-java-awt-font

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Closes #213

Sources

Validation

  • Parsed all five scoped XML files.
  • Confirmed CRLF line endings for all scoped XML files.
  • Confirmed zero To be added placeholders in Java.Awt.Font and ns-Java.Awt.Font.xml.
  • Ran git diff --check.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers
jonathanpeppers requested review from dalexsoto and a lite review from Copilot and removed request for Copilot August 14, 2026 10:52
@jonathanpeppers
jonathanpeppers enabled auto-merge (squash) August 14, 2026 10:52
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

1 similar comment
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/xml/Java.Awt.Font/NumericShaper.xml references nonexistent managed member NumericShaper.Range.EUROPEAN. The binding exposes NumericShaper.Range.European; please use that name so the documented example compiles.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8e26f329-986c-4861-ad65-7581ed5469dd
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto Fixed in 072a732: the managed API reference now uses NumericShaper.Range.European.

@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds/updates XML documentation for the Java.Awt.Font namespace, replacing remaining placeholders and improving API reference text for TextAttribute, NumericShaper, and related range types.

Changes:

  • Replaced the namespace-level “To be added.” summary with a concrete description.
  • Removed placeholder <value> elements across TextAttribute and added standard interop infrastructure docs where applicable.
  • Added/updated summaries for Ranges, NumericShaper.Range members, and parameter documentation in NumericShaper.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/xml/ns-Java.Awt.Font.xml Adds a meaningful namespace summary.
docs/xml/Java.Awt.Font/TextAttribute.xml Removes placeholders and documents interop infrastructure members.
docs/xml/Java.Awt.Font/Ranges.xml Replaces placeholder summary with a concrete description of supported ranges.
docs/xml/Java.Awt.Font/NumericShaper+Range.xml Fills in summaries for many range constants and infrastructure members.
docs/xml/Java.Awt.Font/NumericShaper.xml Improves parameter docs (notably context) and retains reference links.
Suppressed comments (1)

docs/xml/Java.Awt.Font/NumericShaper.xml:1254

  • The "Java documentation" link in this member's points to the 3-parameter overload of NumericShaper.shape, but this binding is the 4-parameter overload that includes a NumericShaper.Range context. This makes the reference link/signature misleading; update the href and displayed signature to match the Range overload.
        <param name="context">The context to which to convert the characters, such as <c>NumericShaper.Range.European</c>.</param>
        <summary>Converts the digits in the text that occur between start and
            start + count.</summary>
        <remarks>
          <para>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The invalid managed member reference is fixed; no blocking issues remain.

@jonathanpeppers
jonathanpeppers merged commit 12a85fe into main Aug 15, 2026
4 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-document-java-awt-font branch August 15, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add XML documentation for Java.Awt.Font

3 participants