Skip to content

Document DocumentBuilder parsing APIs - #499

Merged
jonathanpeppers merged 3 commits into
mainfrom
jonathanpeppers-document-java-xml-parser-apis-19f
Aug 15, 2026
Merged

Document DocumentBuilder parsing APIs#499
jonathanpeppers merged 3 commits into
mainfrom
jonathanpeppers-document-java-xml-parser-apis-19f

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Summary

Sources

Validation

  • Parsed docs/xml/Javax.Xml.Parsers/DocumentBuilder.xml successfully as XML.
  • Confirmed CRLF line endings and no remaining To be added placeholders in DocumentBuilder.ParseAsync members.
  • Ran git diff --check.

Refs #280

Refs #280

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documents the five Javax.Xml.Parsers.DocumentBuilder.ParseAsync overloads by replacing placeholder XML doc text with parameter descriptions, summaries, and return descriptions aligned to the Java/Android API surface.

Changes:

  • Replaced To be added. placeholders for ParseAsync parameters, summaries, and returns across five overloads.
  • Preserved existing attribution/licensing remarks blocks while updating member doc content.
Suppressed comments (4)

docs/xml/Javax.Xml.Parsers/DocumentBuilder.xml:624

  • The wording here deviates from the repository’s common Task documentation style ("A task that represents …") and reads as though the result is always a new/non-null document despite the nullable Task result type.
        <summary>Parses the content of the given input source as an XML document.</summary>
        <returns>A task whose result is a new DOM document.</returns>

docs/xml/Javax.Xml.Parsers/DocumentBuilder.xml:655

  • The phrasing here ("A task whose result …") is inconsistent with the prevailing style in other async docs ("A task that represents …") and may overstate non-nullness given Task<…IDocument?>.
        <summary>Parses the content of the given input stream as an XML document.</summary>
        <returns>A task whose result is a new DOM document.</returns>

docs/xml/Javax.Xml.Parsers/DocumentBuilder.xml:686

  • The line here doesn’t match the common Task documentation wording used elsewhere in this repo ("A task that represents …") and may imply a guaranteed new/non-null result while the signature is Task<…IDocument?>.
        <summary>Parses the content of the given URI as an XML document.</summary>
        <returns>A task whose result is a new DOM document.</returns>

docs/xml/Javax.Xml.Parsers/DocumentBuilder.xml:719

  • The text here uses uncommon wording for Task-returning APIs in this repo ("whose result") and implies a new/non-null document, even though the method signature is Task<…IDocument?>.
        <summary>Parses the content of the given input stream as an XML document.</summary>
        <returns>A task whose result is a new DOM document.</returns>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/xml/Javax.Xml.Parsers/DocumentBuilder.xml Outdated
Comment thread docs/xml/Javax.Xml.Parsers/DocumentBuilder.xml Outdated
Refs #280

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers

Copy link
Copy Markdown
Member Author

Addressed the automated review feedback: the ParseAsync return documentation now describes the parsing task without implying a non-null result.

Refs #280

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers
jonathanpeppers requested review from dalexsoto and removed request for dalexsoto August 14, 2026 23:55
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documented API behavior matches the current contracts; no blocking issues found.

@jonathanpeppers
jonathanpeppers merged commit 751988b into main Aug 15, 2026
3 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-document-java-xml-parser-apis-19f branch August 15, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants