Skip to content

Remove #region directives from Android.Runtime.XmlReaderPullParser#12015

Merged
jonathanpeppers merged 2 commits into
mainfrom
copilot/fix-finder-remove-regions
Jul 13, 2026
Merged

Remove #region directives from Android.Runtime.XmlReaderPullParser#12015
jonathanpeppers merged 2 commits into
mainfrom
copilot/fix-finder-remove-regions

Conversation

Copilot AI commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

XmlReaderPullParser.cs still used #region/#endregion, which conflicts with repository style (no #region). This change removes those directives while preserving section intent as inline comments.

  • Scope

    • Updated only src/Mono.Android/Android.Runtime/XmlReaderPullParser.cs.
    • No functional/API changes; this is a formatting/convention cleanup.
  • Directive cleanup

    • Converted:
      • #region IXmlResourceParser implementation// IXmlResourceParser implementation
      • #region IAttributeSet implementation// IAttributeSet implementation
      • #region IXmlPullParser implementation// IXmlPullParser implementation
    • Removed the three corresponding #endregion lines.
  • Result

    • Section labeling remains readable.
    • File no longer contains #region/#endregion.
// IXmlPullParser implementation
public void DefineEntityReplacementText (string? entityName, string? replacementText)
{
	throw new NotSupportedException ();
}

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove #region/#endregion directives from XmlReaderPullParser Remove #region directives from Android.Runtime.XmlReaderPullParser Jul 8, 2026
Copilot AI requested a review from jonathanpeppers July 8, 2026 02:56
@jonathanpeppers
jonathanpeppers marked this pull request as ready for review July 13, 2026 13:36
Copilot AI review requested due to automatic review settings July 13, 2026 13:36
@jonathanpeppers
jonathanpeppers merged commit b7b58b6 into main Jul 13, 2026
43 checks passed
@jonathanpeppers
jonathanpeppers deleted the copilot/fix-finder-remove-regions branch July 13, 2026 13:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes #region/#endregion directives from XmlReaderPullParser.cs to align with the repository’s “no #region” style guidance, while keeping the same visual section structure via inline comments.

Changes:

  • Replaced three #region … markers with // … section comments.
  • Removed the corresponding #endregion directives.
  • No functional or API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix-finder] Remove #region/#endregion directives from Android.Runtime.XmlReaderPullParser

4 participants