Remove reflection from ImageArtifactDetails/image info merging - #2230
Open
lbussell wants to merge 1 commit into
Open
Remove reflection from ImageArtifactDetails/image info merging#2230lbussell wants to merge 1 commit into
lbussell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the reflection-based merging of ImageArtifactDetails with a new explicit algorithm. Minus the added test code, this results in less code, plus it is trimming/AOT compatible.
Contributes to #314, because I do not want to move ImageArtifactDetails & friends into the Models library while important operations still use Reflection.