Build a project's TcGlobals with its own path map when the framework imports are cached by xperiandri · Pull Request #20476 · dotnet/fsharp

xperiandri · 2026-09-07T10:31:59Z

Fixes #20474

FrameworkImportsCache reused the --pathmap of the first project that filled the cache for every project sharing the same framework set. As a result, a project without a path map could expose path-mapped file names to its consumers, and a project with one could lose it. TcGlobals is now rebuilt when the path map differs.

🤖 Generated with Claude Code

github-actions · 2026-09-07T10:32:10Z

✅ Release notes checked

✅ Found changes and release notes in following paths:

Change path Release notes path Description

`src/Compiler` docs/release-notes/.FSharp.Compiler.Service/11.0.200.md

T-Gro

🤖🕵️ Approved; CI is still running.

T-Gro

🤖🕵️ Please make the description more concise using this guidance. Keep the problem and why the change is needed prominent, using short sentences in simplified technical English. Retain necessary caveats.

github-actions · 2026-09-22T16:45:15Z

🔍 Tooling Safety Check — Affects-Design-Time
Affects-Design-Time: Compiler service or Visual Studio behavior changed.

Generated by PR Tooling Safety Check · gpt56 1.9M · ◷

Copilot

Copilot review overview

🔵 Needs a closer look

Add coverage for a mapped project after an unmapped sibling populates the cache.

Review effort: Lite
Findings: None

What changed in this PR

Fixes framework import cache reuse so each project’s TcGlobals retains its own path map.

Changes:

Rebuilds TcGlobals when pathMap differs.
Applies project-specific path maps in both compiler paths.
Adds regression coverage and release notes.

File	Summary
`tests/FSharp.Compiler.ComponentTests/FSharpChecker/PathMap.fs`	Adds path-map cache regression tests.
`tests/FSharp.Compiler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj`	Includes the new test file.
`src/Compiler/Service/TransparentCompiler.fs`	Applies project-specific path maps.
`src/Compiler/Service/IncrementalBuild.fs`	Handles path-map differences in cached globals.
`docs/release-notes/.FSharp.Compiler.Service/11.0.100.md`	Documents the fix.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

T-Gro

🤖 🕵️ Re-reviewed all recent changes as of 53d5378; LGTM

…imports are cached FrameworkImportsCache keys the framework imports, and the TcGlobals built with them, by the framework set alone. A project reusing the entry got a fresh TcGlobals only when langVersion or realsig differed, and even then took pathMap from the cached instance. Since TypedTreePickle applies that map to every range it writes, the in-memory reference data of each project carried the --pathmap of whichever project filled the cache first, and a project without a map handed its consumers file names nothing on disk matches. pathMap now takes part in the decision like langVersion and realsig, and the new TcGlobals takes it from the project's own TcConfig, in the incremental builder and the transparent compiler alike. Fixes dotnet#20474 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

…ing project Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

`main` opened 11.0.200 for SDK 11.0.200; 11.0.100 has shipped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

…lled the cache Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Takes the test that a project keeps its path map after a sibling without one filled the cache. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

T-Gro

🤖 🕵️ Re-reviewed all recent changes as of 46e85e2; LGTM

Requested change has been done imo

xperiandri requested a review from a team as a code owner September 7, 2026 10:32

github-project-automation Bot added this to F# Compiler and Tooling Sep 7, 2026

github-project-automation Bot moved this to New in F# Compiler and Tooling Sep 7, 2026

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Sep 7, 2026

Add the release note for PR dotnet#20476

54a06cf

github-actions Bot added the AI-Tooling-Check-Scanned-Clean Tooling check: diff analyzed, no interesting infrastructure files label Sep 7, 2026

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Sep 7, 2026

Add the release note for PR dotnet#20476

0c4b74a

xperiandri force-pushed the fix/framework-cache-pathmap branch from 54a06cf to 0c4b74a Compare September 7, 2026 12:52

T-Gro approved these changes Sep 7, 2026

View reviewed changes

github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Sep 7, 2026

xperiandri mentioned this pull request Sep 11, 2026

Name a declaration from a path-mapped assembly from its root once #20518

Open

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Sep 11, 2026

Add the release note for PR dotnet#20476

6a5abf7

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Sep 11, 2026

Add the release note for PR dotnet#20476

93a30a9

xperiandri force-pushed the fix/framework-cache-pathmap branch from 0c4b74a to 93a30a9 Compare September 11, 2026 16:17

github-actions Bot added the ⚠️ Affects-Design-Time Tooling check: PR touches type providers or dependency manager label Sep 11, 2026

This comment has been minimized.

Sign in to view

T-Gro previously requested changes Sep 15, 2026

View reviewed changes

xperiandri mentioned this pull request Sep 16, 2026

Ignore --pathmap in the IDE's F# project options #20470

Merged

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Sep 26, 2026

Add the release note for PR dotnet#20476

73e687e

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Sep 26, 2026

Add the release note for PR dotnet#20476

ec062bd

Copilot AI lite review requested due to automatic review settings September 26, 2026 01:00

xperiandri force-pushed the fix/framework-cache-pathmap branch from 93a30a9 to ec062bd Compare September 26, 2026 01:00

Copilot started reviewing on behalf of xperiandri September 26, 2026 01:01 View session

Copilot AI reviewed Sep 26, 2026

View reviewed changes

xperiandri force-pushed the fix/framework-cache-pathmap branch from 768180c to be55d40 Compare October 2, 2026 16:03

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Oct 2, 2026

Add the release note for PR dotnet#20476

f0e574f

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Oct 2, 2026

Add the release note for PR dotnet#20476

9a3843e

xperiandri force-pushed the fix/framework-cache-pathmap branch from be55d40 to 53d5378 Compare October 8, 2026 01:11

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Oct 8, 2026

Add the release note for PR dotnet#20476

e917df2

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Oct 8, 2026

Add the release note for PR dotnet#20476

27f8858

T-Gro reviewed Oct 9, 2026

View reviewed changes

xperiandri and others added 4 commits October 10, 2026 23:39

Test that a cached framework set does not lend its path map to a sibl…

9320a3e

…ing project Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Add the release note for PR dotnet#20476

34490e5

Move the release note to the version in development

340683f

`main` opened 11.0.200 for SDK 11.0.200; 11.0.100 has shipped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

xperiandri force-pushed the fix/framework-cache-pathmap branch from 53d5378 to 340683f Compare October 10, 2026 22:28

xperiandri added a commit to xperiandri/fsharp that referenced this pull request Oct 10, 2026

Add the release note for PR dotnet#20476

e5c17ae

Test that a project keeps its path map after a sibling without one fi…

46e85e2

…lled the cache Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

T-Gro reviewed Oct 13, 2026

View reviewed changes

abonie approved these changes Oct 13, 2026

View reviewed changes

abonie requested a review from T-Gro October 13, 2026 11:13

abonie added the AI-reviewed PR reviewed by AI review council label Oct 13, 2026

abonie merged commit 59ea46d into dotnet:main Oct 13, 2026
56 checks passed

This was referenced Oct 13, 2026

[release/11.0.2xx] Source code updates from dotnet/fsharp dotnet/dotnet#10074

Open

[main] Source code updates from dotnet/fsharp dotnet/dotnet#10203

Open

Navigation Menu

Repository navigation

Build a project's TcGlobals with its own path map when the framework imports are cached - #20476

Build a project's TcGlobals with its own path map when the framework imports are cached#20476
abonie merged 5 commits into
dotnet:mainfrom
xperiandri:fix/framework-cache-pathmap

xperiandri commented Sep 7, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 7, 2026 •

edited

Loading

Uh oh!

T-Gro left a comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

T-Gro left a comment

Uh oh!

github-actions Bot commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

T-Gro left a comment

Uh oh!

T-Gro left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

xperiandri commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Release notes checked

Uh oh!

T-Gro left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

T-Gro left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

T-Gro left a comment

Choose a reason for hiding this comment

Uh oh!

T-Gro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xperiandri commented Sep 7, 2026 •

edited

Loading

github-actions Bot commented Sep 7, 2026 •

edited

Loading