Skip to content

Provision Git for DartLab PR checkout and Apex tests - #20774

Open
abonie wants to merge 5 commits into
mainfrom
fix-git-dartlab
Open

abonie wants to merge 5 commits into
mainfrom
fix-git-dartlab

Conversation

@abonie

@abonie abonie commented Oct 12, 2026

Copy link
Copy Markdown
Member

Description

Provision DartLab's bundled Git before PR checkout and make it available to the independent Apex build/test process. CloudTest machines without Git on PATH currently fail before snapshot verification.

No associated issue. Verified DartLab.Modules.Git and Install-Git against the production DartLab source. powershell -NoProfile -ExecutionPolicy Bypass -File eng\tests\ApexGit.Tests.ps1 passed all 7 cases; powershell -NoProfile -ExecutionPolicy Bypass -File eng\tests\SetupPrValidation.Tests.ps1 passed all 12 cases. Live CloudTest execution has not been validated.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

Pipeline-only fix; product release notes and performance benchmarks are not applicable.

Provision the Git distribution bundled with DartLab and expose it to both snapshot checkout and independent Apex build/test processes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 34f3e808-c404-4337-8e8c-76fcea75b3ed
@abonie abonie added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Oct 12, 2026
abonie and others added 3 commits October 13, 2026 21:13
Remove base-SHA freshness checks while keeping reviewed-commit identity. Test a verified PR merge for current heads or the exact reviewed commit after newer pushes. Revalidate PR state and target immediately before checkout in both modes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 34f3e808-c404-4337-8e8c-76fcea75b3ed
Set AGENT_WORKFOLDER to the repository root for the Apex process and its build children so MicroBuild receives a nonempty AddSBOM RootDirectory on CloudTest. Cover missing and stale caller workspace values without modifying the caller environment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 34f3e808-c404-4337-8e8c-76fcea75b3ed
Copy Apex TRX results and attachments into CloudTest LoggingDirectory even when setup or build fails. Preserve the original failure, report copy errors separately, and reject successful builds that produce no TRX results.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 34f3e808-c404-4337-8e8c-76fcea75b3ed
@abonie
abonie marked this pull request as ready for review October 14, 2026 12:24
@abonie
abonie requested a review from a team as a code owner October 14, 2026 12:24
@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Oct 14, 2026
@abonie

abonie commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

/dart c0408bc

@github-actions

Copy link
Copy Markdown
Contributor

F# Apex request failed. Workflow details. Use a standalone /dart <sha> or /pr-val <sha> with the full current PR head SHA after reviewing code and pipeline YAML. The PR must target main and the requester needs repository write access and Microsoft-org membership.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants