You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Change FastTree BinFinder to use floats and remove one data copy #1648
However, I couldn't easily remove this copy because doing the copy also changed the VBuffer from float to double. This should also be changed, as recognized by this REVIEW comment in the code:
// REVIEW: Change this, as well as the bin finding code and bin upper bounds, to be Float instead of Double.
This issue is to fix both of these things. First, change BinFinder to work on float instead of double. Then, we can remove this extra copy and just pass in the normal VBuffer<float> to BinFinder, without worrying if it will destroy the buffer.
Triage: This looks like a neat perf optimization without confirmed benefits. In case you get perf numbers for this change and a scenario which is bottleneck on BinFinder, we can reconsider and implement this.
Activity
matouskozak commentedon Oct 23, 2026
Triage: This looks like a neat perf optimization without confirmed benefits. In case you get perf numbers for this change and a scenario which is bottleneck on
BinFinder, we can reconsider and implement this.