Repository navigation
FastForest multithreading #6215
Description
System Information (please complete the following information):
- OS & Version: Windows 10 19044.1706
- ML.NET Version: 1.7.1 x64
- .NET Version: v4.8 x64
Describe the bug
I'm running tests with FastForest on machine with 2 processors with 12 cores each with a total of 48 threads, the program running the test is using 48 threads, but the highest CPU the program gets is 14%, which 7 maybe 8 threads. This leads me to believe the FastForest training algo is doing some locking.
To Reproduce
Steps to reproduce the behavior:
- Create as many threads as the machine has
- var trainer = context.BinaryClassification.Trainers.FastForest(label, numberOfTrees: trees);
- var trained = trainer.Fit(inputs);
- look at CPU usage
Expected behavior
CPU usage at 100% not significantly less
Screenshots, Code, Sample Projects
Additional context
Activity
michaelgsharp commentedon Jun 13, 2022
how many trees are you using? Is there anything else you are doing in your code besides what you listed here?
sretz commentedon Jun 14, 2022
I am using 2 through 21 trees.
Here is what I'm doing on the thread.
tarekgh commentedon Aug 26, 2022
It is possible to be the lock
machinelearning/src/Microsoft.ML.FastTree/FastTree.cs
Line 217 in 9652e59
dotnet-policy-service commentedon Sep 8, 2026
This issue has been marked
needs-author-actionand may be missing some important information.matouskozak commentedon Oct 23, 2026
Triage: This looks like a valid concurrency perf claim. We will investigate when we have more capacity.