Quarantine async IPAddress DNS test on OSX and MacCatalyst - #133946
Conversation
Temporarily suppress the tracked timeout on MacCatalyst only, preserving the existing multithreading condition and other platform coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
There was a problem hiding this comment.
🟡 Changes recommended
The quarantine targets MacCatalyst instead of the reported desktop macOS queues.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Quarantines Dns_GetHostEntryAsync_IPAddress_Ok for issue #132750 using a method-level ActiveIssue.
Changes:
- Adds a platform-specific quarantine attribute.
- Preserves the existing multithreading condition.
- Currently targets MacCatalyst, while reported failures are on desktop macOS.
File summaries
| File | Description |
|---|---|
src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs |
Adds the async DNS test quarantine attribute. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The quarantine targets desktop macOS instead of MacCatalyst, and the attribute indentation is inconsistent.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (1)
src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs:19
- The new attribute is at column 1 while all attributes in this class are indented with the method. Please preserve the file's existing indentation so this declaration remains formatted consistently.
[ActiveIssue("https://github.com/dotnet/runtime/issues/132750", TestPlatforms.OSX)]
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
rzikm
changed the title
rzikm
changed the title
There was a problem hiding this comment.
🟡 Changes recommended
Remove TestPlatforms.OSX or update the stated scope to include desktop macOS.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
|
/backport to release/11.0 |
|
Started backporting to |
Temporarily quarantine
Dns_GetHostEntryAsync_IPAddress_Okon MacCatalyst and OSX for the timeout tracked by #132750.