JIT: Correct typeof(void).IsPrimitive constant folding - #133967
Merged
Merged
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix constant-folding of typeof(void).IsPrimitive to return false
JIT: Correct typeof(void).IsPrimitive constant folding
Sep 15, 2026
Member
|
PTAL @dotnet/jit-contrib |
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The fix and regression coverage address the reported behavior.
Pull request overview
Fixes JIT constant folding so typeof(void).IsPrimitive matches reflection.
Changes:
- Excludes
CORINFO_TYPE_VOIDfrom primitive classification. - Adds regression coverage for
typeof(void).IsPrimitive.
File summaries
| File | Description |
|---|---|
src/tests/JIT/Intrinsics/TypeIntrinsics.cs |
Verifies typeof(void).IsPrimitive is false. |
src/coreclr/jit/importercalls.cpp |
Corrects IsPrimitive constant folding. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
This was referenced Sep 15, 2026
Closed
jakobbotsch
approved these changes
Sep 16, 2026
EgorBo
enabled auto-merge (squash)
September 16, 2026 10:08
Member
|
/ba-g MonoTests failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JIT folds
typeof(void).IsPrimitivetotrue, disagreeing with reflection’sfalse.CORINFO_TYPE_VOIDfrom primitive classification while preserving enum handling.typeof(void)to the existingTypeIntrinsicsnon-primitive assertions.