Only consider ECMA assemblies without DisableRuntimeMarshallingAttribute as having runtime marshalling enabled - #133977
Merged
Merged
Conversation
…ute as having runtime marshalling enabled. Fixes https://developercommunity.visualstudio.com/t/NativeAOT-emits-false-IL1005-for-Disable/11151152
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
jkotas
approved these changes
Sep 15, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Regression coverage for synthetic and ECMA module behavior is still needed.
Get a fresh assessment by requesting another Copilot review.
Review tier: Lite
Findings: 1
Open (1)
What changed in this PR
Updates NativeAOT marshalling detection so only ECMA assemblies without DisableRuntimeMarshallingAttribute are treated as having runtime marshalling enabled.
Changes:
- Corrects non-ECMA module handling.
- Prevents false marshalling diagnostics such as IL1005.
| File | Summary | Review comment |
|---|---|---|
src/coreclr/tools/Common/TypeSystem/Interop/IL/MarshalHelpers.cs |
Corrects runtime-marshalling detection. | Moderate (2 votes): Add regression coverage for synthetic and ECMA modules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://developercommunity.visualstudio.com/t/NativeAOT-emits-false-IL1005-for-Disable/11151152