Revert test tree changes from #133768 - #133979
Open
davidwrighton wants to merge 1 commit into
Open
davidwrighton wants to merge 1 commit into
davidwrighton wants to merge 1 commit into
Conversation
Restore the runtime async test tree to its state before dotnet#133768 while retaining the product changes from that PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 27ac1edf-14a6-4f36-b2d7-87bb83df4db0
github-actions
Bot
added
the
area-Infrastructure-coreclr
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments were identified, and the supplied assessments unanimously find it ready.
Pull request overview
Reverts async test-tree changes from #133768 while retaining product and ReadyToRun changes.
Changes:
- Restores platform build exclusions.
- Removes Wasm opt-in configuration.
- Deletes the diagnostic stack-trace test and project.
File summaries
| File | Description |
|---|---|
src/tests/async/Directory.Build.targets |
Restores platform build exclusions. |
src/tests/async/diagnostic-ip-stacktrace/diagnostic-ip-stacktrace.csproj |
Removes the test project. |
src/tests/async/diagnostic-ip-stacktrace/diagnostic-ip-stacktrace.cs |
Removes the diagnostic stack-trace test. |
src/tests/async/async.csproj |
Removes Wasm opt-in configuration. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/tests/async/Directory.Build.targetsandasync.csprojto their state before Populate runtime-async DiagnosticIP for Wasm R2R #133768Validation
src/tests/asyncpaths exactly match the parent of commite377ef8c333Note
This pull request description was generated with GitHub Copilot.