[release/11.0] Fix NativeAOT resource string inlining for async IL - #134065
Merged
Merged
Conversation
Preserve ECMA module identity for async IL wrappers and recognize it when injecting and resolving resource string tokens. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bf8623a5-a7a4-4c7d-8371-a97b53478abe
github-actions
Bot
requested a review
from MichalStrehovsky
as a code owner
September 16, 2026 14:02
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
MichalStrehovsky
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #133970 to release/11.0
/cc @jakobbotsch
Customer Impact
NativeAOT fails to fold some string resource lookups when used from within async methods. This leads to pulling in a large amount of unnecessary resource machinery, bloating app sizes using string resources for NativeAOT. Reported by customer in #133954.
Regression
Testing
Manual testing on customer's application. NativeAOT outerloop pipeline run.
Risk
Low.