Repository navigation
Conversation
vcsjones
added
the
NO-MERGE
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
vcsjones
commented
Nov 2, 2026
| @@ -81,7 +81,7 @@ internal static unsafe void HKDFDeriveKey( | |||
| { | |||
| Debug.Assert(!destination.IsEmpty); | |||
|
|
|||
| PAL_HashAlgorithm algorithm = PalAlgorithmFromAlgorithmName(hashAlgorithm); | |||
Member
Author
There was a problem hiding this comment.
PalAlgorithmFromAlgorithmName is a shared helper used by many other things, including things that will not support SHA-3 on Apple (Like RSA PSS). Make an HKDF-specific map for now so that we don't light-up the algorithm elsewhere unintentionally.
vcsjones
marked this pull request as ready for review
November 4, 2026 01:09
vcsjones
removed
the
NO-MERGE
Member
Author
|
SHA-3 HKDF passes in CI so we have test coverage. 
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements SHA-3 for HKDF on Apple platforms.
This is the "smallest" SHA-3 feature we can implement. Let's start here to see if we do indeed have CI coverage. If successful, the rest of the SHA-3, PQC, etc. work will be in follow up PRs.