Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 91f565bb-61e6-4d89-b61d-9eb1102e68cf
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates OmniSharp package discovery and downloads to use GitHub Releases, with version-based .NET target selection and refreshed 1.39.15 metadata.
Changes:
- Retrieves the latest version from the
versionbranch. - Selects .NET 6 or .NET 10 packages by version.
- Updates release URLs, hashes, tests, and development configuration.
| File | Description |
|---|---|
test/omnisharp/omnisharpUnitTests/omnisharpPackageCreator.test.ts |
Tests release URLs and framework selection. |
test/omnisharp/omnisharpUnitTests/omnisharpManager.test.ts |
Updates manager and latest-version tests. |
test/omnisharp/omnisharpUnitTests/omnisharpDownloader.test.ts |
Updates release asset URL tests. |
src/omnisharp/omnisharpPackageCreator.ts |
Adds version-aware framework selection and GitHub asset URLs. |
src/omnisharp/omnisharpManager.ts |
Uses the latest-version endpoint and dynamic package suffixes. |
src/omnisharp/omnisharpDownloader.ts |
Downloads and trims the latest version value. |
package.json |
Updates OmniSharp packages, URLs, paths, and hashes. |
.vscode/launch.json |
Updates dependency refresh configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versionbranchnet6.0for OmniSharp 1.39.15 and earlier andnet10.0for 1.39.16 and laterValidation
npm run omnisharptest:unit(403 tests passed, 1 skipped)