Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9c450012-6263-4cd4-9dd7-4e38a81dc8d4
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9c450012-6263-4cd4-9dd7-4e38a81dc8d4
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Update the SDK requirement messaging and localized resources to match the removed settings.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Updates OmniSharp to 2.0.0 with .NET 10-only assets and removes obsolete configuration.
Changes:
- Updates package assets and installation handling.
- Requires the .NET 10 SDK.
- Removes legacy framework and Mono settings.
- Updates tests, localization, and changelog entries.
| File | Summary |
|---|---|
test/omnisharp/omnisharpUnitTests/optionChangeObserver.test.ts |
Updates obsolete option coverage. |
test/omnisharp/omnisharpUnitTests/omnisharpPackageCreator.test.ts |
Tests updated package suffix behavior. |
test/omnisharp/omnisharpUnitTests/omnisharpManager.test.ts |
Updates installation path tests. |
test/omnisharp/omnisharpUnitTests/omnisharpDownloader.test.ts |
Updates downloader tests. |
src/shared/options.ts |
Removes legacy host selection. |
src/omnisharp/requirementCheck.ts |
Raises the SDK requirement. |
src/omnisharp/omnisharpPackageCreator.ts |
Handles version-dependent package suffixes. |
src/omnisharp/omnisharpManager.ts |
Updates installation path handling. |
package.nls.json |
Updates configuration localization strings. |
package.json |
Updates OmniSharp assets and settings. |
CHANGELOG.md |
Documents the OmniSharp upgrade. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Remove the unreachable .NET Framework and Mono launch, requirement, package-selection, reporting, and telemetry paths now that OmniSharp 2.0 only supports .NET 10. Also reject the special dotnet.server.path value 'latest' so server selection cannot be changed remotely. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32b54e6d-2bfe-4a04-a2a5-2ac382534914
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The requirement check may validate a different .NET installation than the one used to launch OmniSharp.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
Resolved since last review (2)
Remove the sdkPath, sdkVersion, and sdkIncludePrereleases settings because OmniSharp 2.0 no longer binds those options. Remove stale localized setting text and legacy host configuration documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32b54e6d-2bfe-4a04-a2a5-2ac382534914
Use DotnetResolver as the single source of truth for .NET 10 requirement validation and OmniSharp launch. Keep dotNetCliPaths scoped to project and debugger CLI discovery, and clarify both setting descriptions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32b54e6d-2bfe-4a04-a2a5-2ac382534914
JoeRobich
marked this pull request as draft
September 19, 2026 00:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omnisharp.useModernNet,omnisharp.monoPath, andomnisharp.sdk*settings and their documentationdotNetCliPathsscoped to project and debugging operationslatestas adotnet.server.pathvalue so the selected OmniSharp version cannot change remotelyThe remaining server-bound configuration was checked against
OmniSharp/omnisharp-roslynmaster at1551011c36ea669ea0fdee3821a344a8cea17fe4; each remaining option is present and consumed upstream.Upstream release: https://github.com/OmniSharp/omnisharp-roslyn/releases/tag/v2.0.0
Validation
npm run compileDevlanguageServerConfigChangeObserver.test.ts: 16 tests passedpackage.nls*.jsonfiles parse successfully