Revert "Use GitHub Releases for OmniSharp packages (#9781)" - #9789
Merged
jasonmalinowski merged 2 commits intoSep 18, 2026
Merged
Conversation
This reverts commit c742bd1.
jasonmalinowski
approved these changes
Sep 18, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Normalize downloaded version text before semver validation and retain trailing-newline coverage.
Review effort: Lite
Findings: None
What changed in this PR
Reverts the GitHub Releases migration and restores the legacy OmniSharp package distribution flow.
Changes:
- Restores Azure Blob Storage URLs and latest-version lookup.
- Pins OmniSharp assets to version 1.39.14 with .NET 6 support.
- Updates tests and dependency-refresh configuration.
| File | Description |
|---|---|
test/omnisharp/omnisharpUnitTests/omnisharpPackageCreator.test.ts |
Updates package URL and suffix expectations. |
test/omnisharp/omnisharpUnitTests/omnisharpManager.test.ts |
Updates manager download and version-discovery tests. |
test/omnisharp/omnisharpUnitTests/omnisharpDownloader.test.ts |
Updates downloader URL expectations. |
src/omnisharp/omnisharpPackageCreator.ts |
Restores Blob Storage package URL generation. |
src/omnisharp/omnisharpManager.ts |
Restores legacy server and latest-version paths. |
src/omnisharp/omnisharpDownloader.ts |
Restores latest-version download behavior. |
package.json |
Pins OmniSharp dependencies and metadata to 1.39.14. |
.vscode/launch.json |
Updates dependency-management configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Newline-terminated version files can fail semver validation and prevent the latest OmniSharp server from starting.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
jasonmalinowski
approved these changes
Sep 18, 2026
jasonmalinowski
enabled auto-merge
September 18, 2026 23:11
jasonmalinowski
deleted the
revert-9781-dev/jorobich/omnisharp-github-releases
branch
September 18, 2026 23:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c742bd1.