Skip to content

fix(Table): ensures search uses initialized search form values on first page load - #8353

Merged
ArgoZhang merged 4 commits into
mainfrom
fix-table-searchform-initalValue
Aug 24, 2026
Merged

fix(Table): ensures search uses initialized search form values on first page load#8353
ArgoZhang merged 4 commits into
mainfrom
fix-table-searchform-initalValue

Conversation

@Tony-ST0754

@Tony-ST0754 Tony-ST0754 commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

fix:修正初始值在页面第一次加载时,查询未生效

Link issues

fixes #8350

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Ensure configured search form values are applied to the table query during the initial page load.

fix:修正初始值在页面第一次加载时,查询未生效
@bb-auto

bb-auto Bot commented Aug 23, 2026

Copy link
Copy Markdown

Thanks for your PR, @Tony-ST0754. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai

sourcery-ai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensures the Table component’s search uses initialized search form values on first page load by lazily creating the search filter from SearchFormItems when _searchFilter is null.

File-Level Changes

Change Details Files
Initialize and use a fallback search filter from SearchFormItems when using the search form so that initial values take effect on first load.
  • Update GetSearches to handle null _searchFilter by constructing a filter from SearchFormItems via ToFilter()
  • Keep existing behavior for non-form searches using Columns and SearchText unchanged
src/BootstrapBlazor/Components/Table/Table.razor.Search.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#8350 Ensure that initial values configured in the SearchForm are applied to the table's first search/query when the page initially loads.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added the chore This are tasks or bot action label Aug 23, 2026
@bb-auto
bb-auto Bot requested a review from ArgoZhang August 23, 2026 09:00
@bb-auto bb-auto Bot added this to the v10.9.0 milestone Aug 23, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d25f5dc) to head (db2bab5).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          771       771           
  Lines        34575     34579    +4     
=========================================
+ Hits         34575     34579    +4     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArgoZhang ArgoZhang changed the title 修正Table组件中SearchForm表单中初始值未查询未生效 fix(Table): ensures search uses initialized search form values on first page load Aug 24, 2026
@ArgoZhang ArgoZhang added bug Something isn't working and removed chore This are tasks or bot action labels Aug 24, 2026
@ArgoZhang
ArgoZhang merged commit c28e98a into main Aug 24, 2026
7 checks passed
@ArgoZhang
ArgoZhang deleted the fix-table-searchform-initalValue branch August 24, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(Table): SearchForm表单中,如果用户给初始值,页面初次加载时,用户给的初始值是否应该生效

2 participants