Skip to content

doc(Tutorials): add pro website screenshot - #8357

Merged
ArgoZhang merged 4 commits into
dotnetcore:mainfrom
h2ls:lee/fix-table-resize-width
Aug 31, 2026
Merged

doc(Tutorials): add pro website screenshot#8357
ArgoZhang merged 4 commits into
dotnetcore:mainfrom
h2ls:lee/fix-table-resize-width

Conversation

@h2ls

@h2ls h2ls commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Link issues

fixes #8389

Summary By Copilot

  • Restore wwwroot/images/tutorials/pro.jpg, which is referenced by the Tutorials Admin page.
  • Display the BootstrapBlazor professional admin system screenshot instead of a broken image.

Regression?

  • Yes
  • No

The referenced image asset was removed while the Tutorials Admin page continued to use it.

Risk

  • High
  • Medium
  • Low

The change only restores a static JPEG asset already referenced by the documentation site.

Verification

  • Manual (required)
  • Automated

Confirmed that Admin.razor references the restored asset and that the JPEG opens successfully at 2002 × 1448.

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

…hile resizing (dotnetcore#8323)

* fix: 拖动调整列宽期间暂停列宽测试,防止 ResizeObserver 恢复拖动前宽度导致 colgroup > col 宽度值闪烁
* fix: 拖动结束或双击自适应后将该列移出自动测量集合,用户显式设定的列宽不再被后续列宽测试覆盖
* fix: 未实际拖动的点击不再触发列宽回调,避免误触 resizer 导致全表列宽被冻结
* fix: 拖动过程中表格重置或销毁时丢弃过期回调,防止写入无效列宽状态

close dotnetcore#8323
Copilot AI lite review requested due to automatic review settings August 25, 2026 01:25
@bb-auto

bb-auto Bot commented Aug 25, 2026

Copy link
Copy Markdown

Thanks for your PR, @h2ls. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto Bot added the bug Something isn't working label Aug 25, 2026
@bb-auto
bb-auto Bot requested a review from ArgoZhang August 25, 2026 01:25
@bb-auto bb-auto Bot added this to the v10.9.0 milestone Aug 25, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="src/BootstrapBlazor/Components/Table/Table.razor.js" line_range="506-509" />
<code_context>
                 originalX = e.clientX ?? e.touches[0].clientX
             },
             e => {
+                resized = true;
                 const eventX = e.clientX ?? e.changedTouches[0].clientX
                 const marginX = eventX - originalX
</code_context>
<issue_to_address>
**issue (bug_risk):** `resized` becomes true for every `mousemove`/`touchmove` event, even when `eventX - originalX` is zero, so moving the pointer without changing the column width still persists column state and invokes `resizeColumnCallback`, freezing a column that was not actually resized.

**Triggers:** When a pointer move event is delivered over the resizer without horizontal displacement, such as vertical pointer movement or duplicate events with the same clientX.

**Suggested fix:** Set `resized` only when the computed horizontal margin is nonzero and the resulting width differs from the starting width.

```suggestion
                const eventX = e.clientX ?? e.changedTouches[0].clientX
                const marginX = eventX - originalX
                let calcColWidth = colWidth + marginX;
                if (calcColWidth < 5) {
                    calcColWidth = 5;
                }
                resized = marginX !== 0 && calcColWidth !== colWidth;
                table.tables.forEach(t => {
                    const group = [...t.children].find(i => i.nodeName === 'COLGROUP')
```
</issue_to_address>

Sourcery assessment

Needs a human reviewer. 1 finding to address first, and if the resizing logic is wrong, the table can save an incorrect column width to local storage and invoke the resize callback with that state, so the bad width can persist after the code is reverted. The impact is bounded to affected table users and can be repaired by resetting or clearing the saved column state; otherwise this is an ordinary UI behavior bug.

Blocking findings: src/BootstrapBlazor/Components/Table/Table.razor.js:509


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread src/BootstrapBlazor/Components/Table/Table.razor.js Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a regression in the Table fixed-header resizing experience where the auto column-width measurement (ResizeObserver-driven applyColumnMinWidth) can interfere with manual drag resizing / auto-fit, causing colgroup > col widths to flicker and stale widths to be persisted.

Changes:

  • Add a table.resizing guard so applyColumnMinWidth won’t run during drag resizing.
  • On drag end / auto-fit, remove the affected column from autoColumns and sync options.columnStates.width so later re-measures/resets don’t restore stale widths.
  • Avoid calling the resize callback when the user clicks a resizer but doesn’t actually move it.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/BootstrapBlazor/Components/Table/Table.razor.js Outdated
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6cf61dc) to head (0dd87dc).

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #8357   +/-   ##
========================================
  Coverage   99.99%   100.00%           
========================================
  Files         771       771           
  Lines       34624     34624           
========================================
+ Hits        34621     34624    +3     
+ Misses          3         0    -3     
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArgoZhang ArgoZhang modified the milestones: v10.9.0, v10.10.0 Aug 30, 2026
@ArgoZhang ArgoZhang changed the title fix(Table): prevent column width test from restoring pre-drag width while resizing doc(Tutorials): add pro website screenshot Aug 31, 2026
@bb-auto bb-auto Bot added documentation Improvements or additions to documentation and removed bug Something isn't working labels Aug 31, 2026
@dotnetcore dotnetcore deleted a comment from sourcery-ai Bot Aug 31, 2026
@ArgoZhang
ArgoZhang merged commit 968d686 into dotnetcore:main Aug 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(Tutorials): add pro website screenshot

3 participants