Harden composer crash paths and large-paste attachments#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The recurring failures came from multiple independent lifecycle defects: popup event filters and queued callbacks could run after their Qt wrappers had started closing, Ollama model selection could emit before its paired input existed, and the React composer bypassed the legacy large-paste attachment path. WebEngine shutdown also lacked an explicit stop/hide phase before Qt teardown.
Validation
python -m pytest graphlink_app/tests: 482 passedpython -m compileall ... graphlink_app: passednpm.cmd run typecheck: passednpm.cmd run build: passedThe patch remains conservative: it preserves the existing bridge contract and native popup ownership while making teardown idempotent and defensive.