Updated Vortex to 'ffe06eb'. - #325
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe pull request updates the Renovate GitHub Action, removes an obsolete ChangesRepository maintenance
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates repository automation metadata and the displayed Vortex reference without changing application dependencies or runtime behavior. The change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Code coverage (threshold: 80%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #325 +/- ##
========================================
Coverage 86.56% 86.56%
========================================
Files 28 28
Lines 655 655
========================================
Hits 567 567
Misses 88 88 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| - name: Run Renovate | ||
| if: steps.check-requirements.outputs.should_run == 'true' | ||
| uses: renovatebot/github-action@39b914146caeff8cd512e61c8992f1d5913af85c # v46.2.5 | ||
| uses: renovatebot/github-action@37beffda261423addd537c33f2d126df7f6ffbab # v46.2.6 |
There was a problem hiding this comment.
Vortex ffe06eb: drevops/vortex#3095
Routine Renovate action bump, SHA-pinned as this repo requires. This is the only consumer-facing file that genuinely changed upstream between 1.41.1 and the installed ref - git diff --name-only 1.41.1 ffe06eb4 returns 12 files and the other 11 are all under .vortex/** (installer sources, its tests and fixtures, the docs site), which never reach a consumer project.
Worth noting what is not in this hunk. The installer also proposed dropping the trailing comment from issues: write in the permissions: block a few lines above. That comment is this project's own, not template content, so it was re-applied on top of the bump rather than accepted as an update. The same re-render also proposed rolling the DB cache key in build-test-deploy.yml back from v26.8.1 to v26.8.0; that file was reverted entirely.
| /docker-compose.override.yml | ||
| /.env.local | ||
| /.ahoy.local.yml | ||
|
|
There was a problem hiding this comment.
Vortex ffe06eb: drevops/vortex#3096
This deletion is the consumer-side consequence of the upstream change this PR installs, so it is worth stating plainly why removing an ignore rule is safe.
The rule was added during the 1.41.1 update, when the installer wrote a .vortex-manifest.json checksum file into the project to record what it had installed. Upstream #3096 removes that mechanism: the installer now derives the previous install state at run time and writes a human-readable .logs/vortex-update.md registry instead, listing for every file both the project change an update replaced and the change the update brings. Nothing writes .vortex-manifest.json any more, and it is absent from the working tree after this run, so the rule names a file that no longer exists.
One caveat for whoever runs the next update. The fix is on Vortex main but not yet in a published release - 1.41.1 is still the latest tag, and the ahoy update-vortex wrapper defaults VORTEX_INSTALLER_URL to the major-pinned https://www.vortextemplate.com/v1/install, which still serves the 1.41.1 build. A plain ahoy update-vortex today will therefore still write .vortex-manifest.json, and with this rule gone it will surface as an untracked file rather than being ignored. Either run the update against the development installer as this PR did, or delete the stray file afterwards.
| [//]: # (DO NOT REMOVE THE BADGE BELOW. IT IS USED BY VORTEX TO TRACK INTEGRATION) | ||
|
|
||
| [](https://github.com/drevops/vortex/tree/1.41.1) | ||
| [](https://github.com/drevops/vortex/tree/ffe06eb) |
There was a problem hiding this comment.
Standard Vortex integration badge bump, tracking the installed ref.
The value is a short SHA rather than a version because the installed ref is unreleased - this PR tracks the head of Vortex main (ffe06eb4), which is two commits ahead of the 1.41.1 tag. There is a 25.11.0 release draft upstream whose body does reference both of those commits, but it is the stale CalVer draft left over from before Vortex returned to SemVer at 1.34.0, so naming the badge after it would point this project at a dead tag line.
The installer writes the full 40-character SHA here; it was shortened by hand, since a 40-character Shields.io badge is unreadable and the short form resolves the same in the GitHub tree URL.
Summary
README.md's Vortex badge now points at commitffe06eb4caf1eec34601122ccd37c7ebd187103donmaininstead of release1.41.1, applied through the development installer atvortex-docs.netlify.app/installbecause the production/v1/installbuild only serves published releases.Because Vortex
ffe06ebis unreleased, the installer's re-render proposed 32 changed files with roughly 2521 deletions - including a rewrite ofweb/modules/custom/do_base/do_base.deploy.phpthat would have dropped 1535 lines of project deploy hooks - so each proposed file was checked againstgit diff --name-only 1.41.1 ffe06eb4in a local Vortex clone to separate genuine upstream content from re-render drift.Only three files land in
develop-.github/workflows/update-dependencies.yml(renovatebot/github-actionv46.2.5 to v46.2.6), theREADME.mdbadge, and the removed/.vortex-manifest.jsonline in.gitignore- whilecomposer.json,composer.lock,package.json, andpackage-lock.jsonstay byte-identical todevelop, so this touches no dependency, PHP, JavaScript, or configuration behaviour.Before / After
Checklist before requesting a review
[#123] Verb in past tense.#123added to descriptionChangedsectionChanged
Vortex update
Update process
Replaced
.vortex-manifest.jsonwith a.logs/vortex-update.mdregistry, so the installer no longer commits a checksum file that described one machine's install rather than the project.The registry names, per file, what the update actually changed, separating genuine upstream content from re-render drift. In this run it flagged 28 of 32 touched files as "The update ships this file unchanged", matching the upstream file list exactly.
Removed the now-dead
/.vortex-manifest.jsonignore rule from.gitignore, since nothing writes that file any more.CI
renovatebot/github-actionto v46.2.6 (SHA-pinned, from v46.2.5) inupdate-dependencies.yml.Dependency updates
None.
composer.json,composer.lock,package.jsonandpackage-lock.jsonare all byte-identical todevelop.The installer's re-render proposed lowering six Composer constraints (
drush/drush,phpstan/phpstan,drupal/lagoon_logs,drupal/devel,drupal/pathauto,drupal/search_api) and two Node devDependencies (prettier,stylelint) to the template's floors. All were rejected as downgrades and the project's pins kept.Screenshots
N/A
Summary by CodeRabbit
Chores
Documentation