Skip to content

Updated Vortex to 'ffe06eb'. - #325

Open
AlexSkrypnyk wants to merge 3 commits into
developfrom
feature/update-vortex-ffe06eb
Open

Updated Vortex to 'ffe06eb'.#325
AlexSkrypnyk wants to merge 3 commits into
developfrom
feature/update-vortex-ffe06eb

Conversation

@AlexSkrypnyk

@AlexSkrypnyk AlexSkrypnyk commented Sep 7, 2026

Copy link
Copy Markdown
Member

Summary

README.md's Vortex badge now points at commit ffe06eb4caf1eec34601122ccd37c7ebd187103d on main instead of release 1.41.1, applied through the development installer at vortex-docs.netlify.app/install because the production /v1/install build only serves published releases.

Because Vortex ffe06eb is unreleased, the installer's re-render proposed 32 changed files with roughly 2521 deletions - including a rewrite of web/modules/custom/do_base/do_base.deploy.php that would have dropped 1535 lines of project deploy hooks - so each proposed file was checked against git diff --name-only 1.41.1 ffe06eb4 in a local Vortex clone to separate genuine upstream content from re-render drift.

Only three files land in develop - .github/workflows/update-dependencies.yml (renovatebot/github-action v46.2.5 to v46.2.6), the README.md badge, and the removed /.vortex-manifest.json line in .gitignore - while composer.json, composer.lock, package.json, and package-lock.json stay byte-identical to develop, so this touches no dependency, PHP, JavaScript, or configuration behaviour.

Before / After

┌─────────────────────────────────────────────┐
│ ffe06eb installer re-render (dev build)      │
│ 32 files proposed, ~2521 deletions           │
├─────────────────────────────────────────────┤
│ do_base.deploy.php            -1535 lines    │
│ drush/drush, phpstan/phpstan     downgrades  │
│ prettier, stylelint              downgrades  │
│ CI database cache key            stale       │
│ 25 more scaffold/config files    drift       │
└─────────────────────────────────────────────┘
                     │
                     │  filter: git diff --name-only 1.41.1 ffe06eb4
                     │  (local Vortex clone) -> 1 file genuinely changed
                     ▼
┌──────────────────────────────────────────────────┐
│ merged to develop (3 commits)                     │
│ 3 files, 6 lines changed                          │
├──────────────────────────────────────────────────┤
│ update-dependencies.yml   renovatebot -> v46.2.6  │
│ README.md                 badge -> ffe06eb        │
│ .gitignore                drop vortex-manifest    │
└──────────────────────────────────────────────────┘

Checklist before requesting a review

  • Subject includes ticket number as [#123] Verb in past tense.
  • Ticket number #123 added to description
  • Added context in Changed section
  • Self-reviewed code and commented in commented complex areas.
  • Added tests for fix/feature.
  • Relevant tests run and passed locally.

Changed

Vortex update

Update process

  • Replaced .vortex-manifest.json with a .logs/vortex-update.md registry, so the installer no longer commits a checksum file that described one machine's install rather than the project.

  • The registry names, per file, what the update actually changed, separating genuine upstream content from re-render drift. In this run it flagged 28 of 32 touched files as "The update ships this file unchanged", matching the upstream file list exactly.

  • Removed the now-dead /.vortex-manifest.json ignore rule from .gitignore, since nothing writes that file any more.

CI

  • Bumped renovatebot/github-action to v46.2.6 (SHA-pinned, from v46.2.5) in update-dependencies.yml.

Dependency updates

None. composer.json, composer.lock, package.json and package-lock.json are all byte-identical to develop.

The installer's re-render proposed lowering six Composer constraints (drush/drush, phpstan/phpstan, drupal/lagoon_logs, drupal/devel, drupal/pathauto, drupal/search_api) and two Node devDependencies (prettier, stylelint) to the template's floors. All were rejected as downgrades and the project's pins kept.

Screenshots

N/A

Summary by CodeRabbit

  • Chores

    • Updated the automated dependency-management workflow.
    • Removed an ignore rule for a generated manifest file.
  • Documentation

    • Updated the Vortex badge reference in the README.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 5dededfd-02cc-42cc-bd4a-127bca27552f

📥 Commits

Reviewing files that changed from the base of the PR and between 2e1406e and eeda747.

📒 Files selected for processing (3)
  • .github/workflows/update-dependencies.yml
  • .gitignore
  • README.md
💤 Files with no reviewable changes (1)
  • .gitignore

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The pull request updates the Renovate GitHub Action, removes an obsolete .gitignore entry, and changes the Vortex badge to reference a commit.

Changes

Repository maintenance

Layer / File(s) Summary
Automation and project metadata updates
.github/workflows/update-dependencies.yml, .gitignore, README.md
The Renovate action changes from v46.2.5 to v46.2.6. The .vortex-manifest.json ignore rule and comments are removed. The Vortex badge changes from version 1.41.1 to commit ffe06eb.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to eeda7

This updates repository automation metadata and the displayed Vortex reference without changing application dependencies or runtime behavior. The change is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: updating Vortex references to commit ffe06eb. It is concise and related to the pull request objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/update-vortex-ffe06eb

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Code coverage (threshold: 80%)

  Classes: 51.85% (14/27)
  Methods: 77.17% (71/92)
  Lines:   89.15% (756/848)
Per-class coverage
Drupal\do_ai_alt_text\AltTextGenerator
  Methods:  85.71% ( 6/ 7)   Lines:  98.72% ( 77/ 78)
Drupal\do_ai_alt_text\Plugin\Action\RegenerateImageAltText
  Methods: 100.00% ( 8/ 8)   Lines: 100.00% ( 63/ 63)
Drupal\do_base\EventSubscriber\PreviewLinkCacheSubscriber
  Methods:  33.33% ( 1/ 3)   Lines:  11.11% (  1/  9)
Drupal\do_base\EventSubscriber\ThemeColorSubscriber
  Methods:  66.67% ( 2/ 3)   Lines:  40.00% (  4/ 10)
Drupal\do_base\Hook\AutomatedListPagerHook
  Methods: 100.00% ( 5/ 5)   Lines: 100.00% ( 31/ 31)
Drupal\do_base\Hook\LibraryInfoAlterHook
  Methods: 100.00% ( 3/ 3)   Lines: 100.00% (  9/  9)
Drupal\do_base\Hook\MetatagsAlterHook
  Methods: 100.00% ( 7/ 7)   Lines: 100.00% ( 58/ 58)
Drupal\do_base\Hook\PageAttachmentsHook
  Methods:  87.50% ( 7/ 8)   Lines:  94.92% ( 56/ 59)
Drupal\do_base\NavigationScriptHash
  Methods: 100.00% ( 3/ 3)   Lines: 100.00% ( 27/ 27)
Drupal\do_base\Twig\ImageDimensionsExtension
  Methods:  40.00% ( 2/ 5)   Lines:  81.48% ( 44/ 54)
Drupal\do_content_api\EventSubscriber\JsonApiWriteGateSubscriber
  Methods:  66.67% ( 2/ 3)   Lines:  88.89% (  8/  9)
Drupal\do_content_api\Hook\EntityCreateAccessHook
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 12/ 12)
Drupal\do_content_api\Hook\ModerationPolicyHook
  Methods:  50.00% ( 1/ 2)   Lines:  93.75% ( 15/ 16)
Drupal\do_content_api\Routing\RouteSubscriber
  Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  6/  6)
Drupal\do_feed\FeedUrlBuilder
  Methods: 100.00% ( 4/ 4)   Lines: 100.00% ( 18/ 18)
Drupal\do_feed\Form\FeedSettingsForm
  Methods: 100.00% ( 4/ 4)   Lines: 100.00% ( 15/ 15)
Drupal\do_feed\Hook\EntityDeleteHook
  Methods:  50.00% ( 1/ 2)   Lines:  92.31% ( 12/ 13)
Drupal\do_feed\Hook\EntityPresaveHook
  Methods: 100.00% ( 4/ 4)   Lines: 100.00% ( 54/ 54)
Drupal\do_feed\Hook\PreprocessParagraphHook
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 14/ 14)
Drupal\do_feed\Hook\PreprocessViewsViewRowRssHook
  Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  3/  3)
Drupal\do_feed\Hook\ViewsPreViewHook
  Methods:  50.00% ( 1/ 2)   Lines:  96.43% ( 27/ 28)
Drupal\do_generated_content\Generator\CaseMatrix
  Methods: 100.00% ( 3/ 3)   Lines: 100.00% ( 12/ 12)
Drupal\do_generated_content\Generator\RelativeDate
  Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  1/  1)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.56%. Comparing base (2e1406e) to head (eeda747).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #325   +/-   ##
========================================
  Coverage    86.56%   86.56%           
========================================
  Files           28       28           
  Lines          655      655           
========================================
  Hits           567      567           
  Misses          88       88           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- name: Run Renovate
if: steps.check-requirements.outputs.should_run == 'true'
uses: renovatebot/github-action@39b914146caeff8cd512e61c8992f1d5913af85c # v46.2.5
uses: renovatebot/github-action@37beffda261423addd537c33f2d126df7f6ffbab # v46.2.6

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vortex ffe06eb: drevops/vortex#3095

Routine Renovate action bump, SHA-pinned as this repo requires. This is the only consumer-facing file that genuinely changed upstream between 1.41.1 and the installed ref - git diff --name-only 1.41.1 ffe06eb4 returns 12 files and the other 11 are all under .vortex/** (installer sources, its tests and fixtures, the docs site), which never reach a consumer project.

Worth noting what is not in this hunk. The installer also proposed dropping the trailing comment from issues: write in the permissions: block a few lines above. That comment is this project's own, not template content, so it was re-applied on top of the bump rather than accepted as an update. The same re-render also proposed rolling the DB cache key in build-test-deploy.yml back from v26.8.1 to v26.8.0; that file was reverted entirely.

Comment thread .gitignore
/docker-compose.override.yml
/.env.local
/.ahoy.local.yml

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vortex ffe06eb: drevops/vortex#3096

This deletion is the consumer-side consequence of the upstream change this PR installs, so it is worth stating plainly why removing an ignore rule is safe.

The rule was added during the 1.41.1 update, when the installer wrote a .vortex-manifest.json checksum file into the project to record what it had installed. Upstream #3096 removes that mechanism: the installer now derives the previous install state at run time and writes a human-readable .logs/vortex-update.md registry instead, listing for every file both the project change an update replaced and the change the update brings. Nothing writes .vortex-manifest.json any more, and it is absent from the working tree after this run, so the rule names a file that no longer exists.

One caveat for whoever runs the next update. The fix is on Vortex main but not yet in a published release - 1.41.1 is still the latest tag, and the ahoy update-vortex wrapper defaults VORTEX_INSTALLER_URL to the major-pinned https://www.vortextemplate.com/v1/install, which still serves the 1.41.1 build. A plain ahoy update-vortex today will therefore still write .vortex-manifest.json, and with this rule gone it will surface as an untracked file rather than being ignored. Either run the update against the development installer as this PR did, or delete the stray file afterwards.

Comment thread README.md
[//]: # (DO NOT REMOVE THE BADGE BELOW. IT IS USED BY VORTEX TO TRACK INTEGRATION)

[![Vortex](https://img.shields.io/badge/Vortex-1.41.1-65ACBC.svg)](https://github.com/drevops/vortex/tree/1.41.1)
[![Vortex](https://img.shields.io/badge/Vortex-ffe06eb-65ACBC.svg)](https://github.com/drevops/vortex/tree/ffe06eb)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standard Vortex integration badge bump, tracking the installed ref.

The value is a short SHA rather than a version because the installed ref is unreleased - this PR tracks the head of Vortex main (ffe06eb4), which is two commits ahead of the 1.41.1 tag. There is a 25.11.0 release draft upstream whose body does reference both of those commits, but it is the stale CalVer draft left over from before Vortex returned to SemVer at 1.34.0, so naming the badge after it would point this project at a dead tag line.

The installer writes the full 40-character SHA here; it was shortened by hand, since a 40-character Shields.io badge is unreadable and the short form resolves the same in the GitHub tree URL.

@AlexSkrypnyk AlexSkrypnyk added the Needs review Pull request needs a review from assigned developers label Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs review Pull request needs a review from assigned developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants