docs: xtend-to-java skill — review trims and staleness fixes#1464
Merged
joaodinissf merged 1 commit intoJul 16, 2026
Merged
Conversation
Applies the adversarially-verified findings of the skill review (13-agent Opus panel over the stacked dsldevkit#1453+dsldevkit#1461 state; 25 confirmed findings): Cuts: duplicate string-decision list in 00-decisions; duplicated commit-message fence in multi-file-batch; four known-pitfalls rows that were verbatim checklist echoes; copyright restatements reduced to pointers (formatting-and-commit stays canonical). Staleness/contradictions: one-file-conversion step 8 and the checklist final invariant now teach the two-step rename+translate scheme; stale hard-coded rule counts dropped; overview slice branch now based on upstream/master; import order stated once (java.* -> org.* -> com.*, junit inside org, static block separate) and aligned in rule 11 and the pitfalls row; == equality rule gains the primitive-operand carve-out (enums stay object-form); rollback recipe corrected for two-step slices (reset --hard HEAD~N / revert both shas, never -m 1) and stated once; SKILL.md lambda cheat-sheet aligned with 07 (expression form); Pairs guidance defers to the no-xbase.lib pitfall; dead "ledger's Method 1" pointer removed. Small additions: trailing-\s trap noted at point of use in 4.3; stable-rule-ID legend in the checklist header; overview Step 0 leads with the bash listing; examples no longer claim their whitespace WAS verified (they illustrate; real migrations must verify) and use the PMD-safe explicit StringBuilder capacity. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ANGM7L3BaEGfGUmPVKRt4
joaodinissf
force-pushed
the
docs/xtend-skill-review-trims
branch
from
3a338b5 to
73a4eac
Compare
rubenporras
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the verified findings of a full skill review (multi-agent, adversarially verified — 25 confirmed findings, run against the skill as it will look once #1453 and #1461 merge).
Cuts (no operative detail lost): duplicate string-decision list in
00-decisions; duplicated commit-message fence inmulti-file-batch; fourknown-pitfallsrows that were verbatim checklist echoes; copyright restatements reduced to pointers (formatting-and-commitis canonical).Staleness / contradictions fixed:
one-file-conversionstep 8 and the checklist's final invariant now teach the two-step rename→translate scheme; stale hard-coded rule counts dropped ("all 30/34"); slice branches now based onupstream/master; import order stated once —java.*→org.*→com.*,junit.*insideorg.*, static imports separate — and aligned across rule 11 and the pitfalls row (the previous three statements disagreed, and01's own example violated itself);==equality rule gains the primitive-operand carve-out (enums stay object-form); rollback recipe corrected for two-step slices (reset --hard HEAD~N/revertboth shas — never-m 1) and stated once; SKILL.md lambda cheat-sheet aligned with07-lambdas(expression form); Pairs guidance defers to the no-xbase.libpitfall; dead "ledger's Method 1" pointer removed.Small additions: trailing-
\strap at point of use in §4.3; stable-rule-ID legend in the checklist header (IDs are not a sequence — do not renumber); overview Step 0 leads with the bash listing; examples reframed to say whitespace must be verified (they illustrate shape) and use the PMD-safe explicitStringBuildercapacity.Net: 14 files, +57/−55.
Note: stacked on #1453 + #1461 — their commits appear in this diff until they merge.
🤖 Generated with Claude Code