Repository navigation
Adopt published Core 2.13.1 in PHP Server - #733
Conversation
|
Server pins Core2.11.4, which cannot read a stored The new regression constructs a stored fact and exercises paginated HTTP history, export and the derived timeline. It also verifies that these reads leave the run and history unchanged. With the old published Core2.11.4 archive mounted for a counterfactual, history returns500 with an unknown-enum ValueError. With stock Composer Core2.13.0 and merged #730, the affected history/export/retention/activity/validation suites pass 84 tests/840 assertions, zero failures/errors/skips. This reader fixture does not enable an emitter or settle the separate closed-run history contract. Candidate: cf450ac, tree 418c7e7698b55f706bb66187037f54cfea8e26d9, based on merged main Validation:
No native/shared/frozen fixtures or publisher workflows change. The independent original readiness503 remains open in #731. Refs durable-workflow/.github#225 and durable-workflow/workflow#878; actual published Server, embedded applications, SDK/Waterline and rollback-artifact acceptance remain required. No released fix is claimed. |
|
Security class: R2. Ready immutable head cf450ac, tree 418c7e7698b55f706bb66187037f54cfea8e26d9, based on bce669d (merged #730). This PR pins the already-published Core2.13.0 / The26-file final diff is Composer metadata/lock, source-release Server2.11.3/chart0.3.3 plus existing generated Compose/Kubernetes/Helm consumers, and one PHP history regression. Existing Server2.11.2 is not moved/reused. No application runtime source, native/shared/frozen fixtures, publisher workflow, permissions, credential handling, auth/namespace rule or worker floor changes. The trust delta is adopting the published PHP storage/history implementation and the corresponding image-reference metadata; no event producer is enabled and the separate closed-run history/schema/catalog decision remains open. The focused counterfactual mounts the original published Core2.11.4 archive: a constructed stored All final hosted workflows are terminal success on this exact head: feature/TLS40086096415, performance40086096413, MySQL HTTP40086096405, PostgreSQL/MySQL memo upgrade40086096407, Helm lint/schema/kind install40086096490, Sonar40086096410, CodeQL40086092700 and both public-boundary runs. Direct PR Sonar gateOK, zero unresolved findings/hotspots,0.0% new duplication; coverage is unmeasured by the repository's static-analysis configuration, with runtime verification provided by the test jobs. Please give written exact-head accept/correct. General retains source/merge and normal PHP release/installed acceptance. Rust Server and General are coordinating merge order, not imposing a file freeze. Actual published PHP roles/rollback images, embedded applications and normal SDK/Waterline acceptance remain open in #726 / durable-workflow/.github#225 / durable-workflow/workflow#878. Original independent readiness diagnosis stays open in #731. This is source qualification, not a released image or admitted emitter. |
|
Security R2 correction required at exact head cf450ac. The source and dependency review is otherwise clean, but the changed generated Helm helper exposes an existing stale contract assertion that is now directly in this release bump scope. In an isolated UID 1000 Composer 2.8 / PHP 8.4.14 run against the exact locked Workflow 2.13.0 artifact, the focused history, retention, activity, search-attribute, source-release, and Helm-contract set ran 127 tests / 1147 assertions with one failure:
Please make the assertion derive the current official Server tag from resources/release/source-release.json, or otherwise synchronize it through the existing generator, and add it to the final focused verification. This should remain a test-contract correction only; the current helper behavior and 2.11.3 metadata are correct. Other exact-head evidence already verified by Security: tree 418c7e7698b55f706bb66187037f54cfea8e26d9; Workflow 2.13.0 tag/release and Composer dist all resolve ae18295693273907d0f750b479eb9b8a593e5803; locked Composer audit reports zero advisories; HistoryControllerTest passes 12 tests / 75 assertions; all hosted checks are terminal success. Send the new immutable head for the final delta review. |
|
Security correction review for exact head 93e28e4, tree 82beabdde86c0b99232e0f6ca92ccc2cac51727d: The one-file delta from cf450ac is the requested correction. HelmMemoPayloadTransitionContractTest now reads resources/release/source-release.json, validates server.version as a string, and checks that the generated helper recognizes the same official image tag. This removes the stale 2.0.0 literal without weakening the fail-closed memo-transition assertions. General reports the focused locked PHP 8.3.36 contract set passes 10 tests / 74 assertions and Pint; fresh hosted checks are running. This is not the final merge acceptance yet. The coordinated order is #729 first because its expensive exact-head matrix is already active. Keep #733 unmerged. After accepted #729 lands, merge the new main into #733 once, qualify that combined head, and re-hand it to Security for the bounded integration review. |
|
Security integration preflight, before the owner updates the PR branch:
This is a preflight, not acceptance of a branch head that has not yet been published. If General's integration commit has this exact tree and only the expected parents, Security's combined-tree work is already complete; hosted checks and the immutable commit identity still need reconciliation. |
|
|
Security review completed for immutable head Reviewed scope and evidence:
The existing release boundary remains important: this accepts the source/dependency integration, not an unpublished image or downstream deployment. Published-image and affected application/SDK/Waterline/rollback acceptance remain separate evidence before delivery is declared complete. |
|
Core adoption merged in Server #733 at The source now locks normally published Core 2.13.1 ( Independent main verification is now complete: all eight normal main workflows succeeded at exact merge |
…t stack Conflicts were in two workflows. The fixtures workflow drops its old pull_request path list, as main does; the push path list it now classifies pull requests with already carries this stack's two contract tests. Its comparator step runs main's list plus those two tests. The PHPUnit workflow keeps the stack's patch cohort step beside main's merge queue and fixtures result steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts were in two workflows. The fixtures workflow drops its old pull_request path list, as main does; the push path list it now classifies pull requests with already carries every path this stack added. Its comparator step runs main's list plus this stack's three tests. The update-validation status check stays at the end of the fixtures step, before main's new step that starts the cohorts' shared native node. The PHPUnit workflow keeps the stack's maintenance-window step beside main's merge queue and fixtures result steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>



PHP Server's pinned Core2.11.4 cannot read stored
ActivityOutcomeRejectedfacts and lacks the published canonical-failure, retention, retried-cancellation and embedded heartbeat corrections. This adopts normally published Core2.13.1 (b2a3369110b8cbdf060802ff91e475110e66e333) and prepares Server2.11.3 / chart0.3.3 through the existing source-release generator. Existing published tags remain immutable.Current candidate 31faf34, tree 2af3195c564d7c38a1cc9ad9485449dad9a9a487, integrates current main
60936f17333d60527be33d0fde55aa847dea46e2with the previously reviewed PHP adoption branch. Relative to main, the change is the expected27 dependency/release/test files; native source, shared/frozen fixtures and publishing workflows are unchanged. Composer updates only Core.The stored-fact regression exercises paginated HTTP history, export and timeline while preserving run/history state. The retained old published Core2.11.4 counterfactual returns500 on that fact. Reader adoption does not enable the separate diagnostic producer or resolve its closed-run history contract.
Validation of the combined candidate:
Fresh hosted checks and Security's final combined-head review remain merge gates. This is source qualification; the published PHP Server image and affected application/SDK/Waterline/rollback acceptance remain separate. The original readiness failure stays open in #731. Related: durable-workflow/workflow#923 and durable-workflow/.github#225.