Repository navigation
Conversation
Each cell takes about a minute beside database parts that take half an hour, so the matrix only held five extra runners per run. One job now runs every cell in its own scope; a failed cell still lets the others run, and the job fails after all of them, as the matrix did. A shell test pins that.
|
|
Independent CI wrapper review of
Please retire each cell's exact resources on both success and failure before the next cell starts, preserving diagnostics, aggregate failure and the final Verification: the three existing wrapper tests pass in an isolated Node container. An additional stub-only control-flow counterfactual returns wrapper exit1 while confirming the failed-cell marker remains present when the next cell starts. No native service, compiler, workload or native log/artifact retrieval was involved. This identifies a source failure-path gap; it does not attribute the hosted deadline-health failure to that gap. |



Review class: R0 (CI efficiency; same checks, same failure semantics).
Why
#746's measured run (40104569657) shows the six
codec-deadline-healthmatrix cells taking 1m03s–1m27s each, while the database parts beside them take 20–31 minutes. Each cell still held a runner. Under org-wide queueing (18 queued jobs observed at 14:33Z), that is five extra runners per run for no wall-time gain.What
codec-deadline-healthjob runs the six cells in turn: sqlite, postgres-16, postgres-17, mysql-8.0, mysql-8.4, mariadb-10.11.scripts/conformance/server-parity/codec-deadline-cells.shruns each cell under its own scope,$RESOURCE_SCOPE-<database>. A failed cell still lets every later cell run, and the job fails after all of them, as the matrix did withfail-fast: false. Per-cell exit statuses are kept ascodec-evidence/<database>.status.always()step removes every cell's exact owned resources by name.needs: [published-sdk-adapters, codec-native-build], so the aggregate and structure tests are unchanged.Evidence
tests/Unit/ServerParityCodecDeadlineCellsTest.mjs(3/3) runs the runner with a stub cell and proves:::error::;ServerParityAggregateTestandServerParityPartsTestpass.