Skip to content

Cancel superseded PHPUnit runs per pull request #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmcdaniel merged 5 commits into from
Oct 24, 2026
Merged

Cancel superseded PHPUnit runs per pull request #751

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4eea5a9
Cancel superseded PHPUnit pull request cycles
rmcdaniel Oct 24, 2026
f834c12
Clarify that concurrency supersedes triggered PR cycles
rmcdaniel Oct 24, 2026
fc4f0fd
Allow superseded PHPUnit jobs to honor cancellation
rmcdaniel Oct 24, 2026
3e4267a
Preserve the reviewed failure-reporting guard when cancelling jobs
rmcdaniel Oct 24, 2026
d5bf1d0
Let superseded source qualification finish as cancelled
rmcdaniel Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/phpunit-feature.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ on:
permissions:
contents: read

# A new PR cycle supersedes its previous qualification. Main and manual runs
# keep distinct run IDs so each requested qualification can finish.
concurrency:
group: phpunit-feature-${{ github.event_name }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
action-policy:
name: Central action policy preflight
Expand Down Expand Up @@ -116,7 +122,8 @@ jobs:
feature:
name: PHPUnit feature suite
needs: action-policy
if: ${{ always() }}
# Report policy failures while allowing cancelled revisions to stop.
if: ${{ always() && !cancelled() }}
runs-on: ubuntu-latest
timeout-minutes: 25
steps:
Expand Down Expand Up @@ -345,7 +352,7 @@ jobs:
qualification:
name: Feature source qualification
needs: [preflight, feature]
if: ${{ always() }}
if: ${{ always() && !cancelled() }}
runs-on: ubuntu-latest
timeout-minutes: 2

Expand Down
Loading