Skip to content

feat: allow mariadb as database backend #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmcdaniel merged 2 commits into from
Sep 9, 2026
+37 −9
Merged

feat: allow mariadb as database backend #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72ac6b7
feat: allow mariadb as database backend
beschoenen Sep 9, 2026
8cb587e
test: exercise native MariaDB readiness and replay in CI
durable-workflow-ops Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,13 +888,18 @@ jobs:
resolve_service redis 6379 "$REDIS_PUBLISHED_PORT" REDIS
} >> "$GITHUB_ENV"

- name: Run bounded locking and history regressions on MariaDB 10.5
run: >-
vendor/bin/phpunit --testdox --testsuite feature
--filter
'/(testHistoryPayloadPaginatedUsesConfiguredSummaryCountersWithoutHydratingHistory|testHistoryPayloadPaginatedUsesBoundedAggregatesWhenSummaryIsMissingOrStale|testEmbeddedHeartbeatAndTimeoutEnforcementUseOneConcurrentLockOrder)/'
tests/Feature/V2/V2WorkflowTaskBridgeTest.php
tests/Feature/V2/V2ActivityTimeoutTest.php
- name: Run locking, readiness and replay regressions on MariaDB 10.5
run: |
vendor/bin/phpunit --testdox --testsuite feature \
--filter '/(testHistoryPayloadPaginatedUsesConfiguredSummaryCountersWithoutHydratingHistory|testHistoryPayloadPaginatedUsesBoundedAggregatesWhenSummaryIsMissingOrStale|testEmbeddedHeartbeatAndTimeoutEnforcementUseOneConcurrentLockOrder)/' \
tests/Feature/V2/V2WorkflowTaskBridgeTest.php \
tests/Feature/V2/V2ActivityTimeoutTest.php
DB_CONNECTION=mariadb vendor/bin/phpunit --testdox --testsuite feature \
--filter '/(testSnapshotSummarizesDurableBacklogRepairCompatibilityAndWorkerFleet|testPublicReplayerCanReplayLiveRun|testPublicReplayerCanReplayHistoryExportBundle|testHistoryPayloadPaginatedUsesConfiguredSummaryCountersWithoutHydratingHistory|testHistoryPayloadPaginatedUsesBoundedAggregatesWhenSummaryIsMissingOrStale|testEmbeddedHeartbeatAndTimeoutEnforcementUseOneConcurrentLockOrder)/' \
tests/Feature/V2/V2OperatorMetricsTest.php \
tests/Feature/V2/V2WorkflowReplayerTest.php \
tests/Feature/V2/V2WorkflowTaskBridgeTest.php \
tests/Feature/V2/V2ActivityTimeoutTest.php
env:
APP_KEY: base64:i3g6f+dV8FfsIkcxqd7gbiPn2oXk5r00sTmdD6V5utI=
DB_CONNECTION: mysql
Expand Down
6 changes: 5 additions & 1 deletion src/V2/Support/BackendCapabilities.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ private static function database(?string $configuredConnection = null): array
: self::normalize(config(sprintf('database.connections.%s.driver', $connection)));
$issues = [];

$driverSupported = is_string($driver) && in_array($driver, ['mysql', 'pgsql', 'sqlite', 'sqlsrv'], true);
$driverSupported = is_string($driver) && in_array(
$driver,
['mysql', 'mariadb', 'pgsql', 'sqlite', 'sqlsrv'],
true
);

if ($connection === null || $driver === null) {
$issues[] = self::issue(
Expand Down
2 changes: 1 addition & 1 deletion src/V2/Support/ReadinessContract.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public static function definition(): array
],
'backend_capabilities' => [
'database' => [
'supported_drivers' => ['mysql', 'pgsql', 'sqlite', 'sqlsrv'],
'supported_drivers' => ['mysql', 'mariadb', 'pgsql', 'sqlite', 'sqlsrv'],
'required_capabilities' => ['transactions', 'after_commit_callbacks', 'durable_ordering'],
'sqlite_note' => 'SQLite is supported with limited concurrent write safety and no row-lock capability.',
],
Expand Down
19 changes: 19 additions & 0 deletions tests/Unit/V2/BackendCapabilitiesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ public function testSnapshotIncludesFrozenReadinessContractMatrix(): void
$contract['surfaces']['claim']['authority']
);
$this->assertContains('mysql', $contract['backend_capabilities']['database']['supported_drivers']);
$this->assertContains('mariadb', $contract['backend_capabilities']['database']['supported_drivers']);
$this->assertContains('pgsql', $contract['backend_capabilities']['database']['supported_drivers']);
$this->assertSame(
'error',
Expand Down Expand Up @@ -148,6 +149,24 @@ public function testSnapshotDoesNotAdvertiseDatabaseCapabilitiesForUnsupportedDr
], $snapshot['database']['capabilities']);
}

public function testSnapshotSupportsTheMariaDbDriver(): void
{
config()->set('database.connections.mariadb.driver', 'mariadb');

$snapshot = BackendCapabilities::snapshot(databaseConnection: 'mariadb');

$this->assertSame('mariadb', $snapshot['database']['connection']);
$this->assertSame('mariadb', $snapshot['database']['driver']);
$this->assertTrue($snapshot['database']['supported']);
$this->assertNotContains('database_driver_unsupported', array_column($snapshot['issues'], 'code'));
$this->assertSame([
'transactions' => true,
'after_commit_callbacks' => true,
'durable_ordering' => true,
'row_locks' => true,
], $snapshot['database']['capabilities']);
}

// ---------------------------------------------------------------
// Structural limits in backend contract
// ---------------------------------------------------------------
Expand Down