kpatch-build: ignore gendwarfksyms and export_symbol local symbols - #1521
Merged
Conversation
kpatch-build: ignore gendwarfksyms and export_symbol local symbols
Kernel v6.18 introduced two new families of local symbols that are
generated in each object file but discarded during the final link of
vmlinux:
- __export_symbol_<name>: generated by the .export_symbol section
of the reworked EXPORT_SYMBOL() macro (include/linux/export.h)
- __gendwarfksyms_ptr_<name>: generated when CONFIG_GENDWARFKSYMS=y
to force DWARF emission for exported symbols
Because these symbols only exist in per-object files and are absent
from the vmlinux symbol table, create-diff-object's find_local_syms()
fails to match them when comparing the patched object's local symbols
against the parent symbol table, e.g.:
create-diff-object: ERROR: mm/vmscan.o: find_local_syms: 219:
couldn't find matching vmscan.c local symbols in vmlinux symbol table
Add them to maybe_discarded_sym() so they are skipped when comparing
local symbol tables.
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kpatch-build: ignore gendwarfksyms and export_symbol local symbols
Kernel v6.18 introduced two new families of local symbols that are generated in each object file but discarded during the final link of vmlinux:
Because these symbols only exist in per-object files and are absent from the vmlinux symbol table, create-diff-object's find_local_syms() fails to match them when comparing the patched object's local symbols against the parent symbol table, e.g.:
create-diff-object: ERROR: mm/vmscan.o: find_local_syms: 219:
couldn't find matching vmscan.c local symbols in vmlinux symbol table
Add them to maybe_discarded_sym() so they are skipped when comparing local symbol tables.