ci(workflow): add stats validation workflow and schema checks - #432
Closed
vjymisal0 wants to merge 1 commit into
Closed
ci(workflow): add stats validation workflow and schema checks#432vjymisal0 wants to merge 1 commit into
vjymisal0 wants to merge 1 commit into
Conversation
Collaborator
|
Hey @vjymisal0 So this is going to run on more than just the CI Stats PR, which is not what we want. Also, you're creating brand new schemas when we already have some we can reuse. We're currently adding versioning to the schema, and I wasn't ready for someone to jump on this issue straight away. I am going to take it down for now and close this PR. If you would like to get involved, let me know, as I have some other areas you can work on :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #431.
Summary of Changes
Validation Workflow (
.github/workflows/validate-stats-pr.yml):packages/starter-*/ci-stats.json,packages/app-*/ci-stats.json,packages/docs/src/content/**).validate:jsonacross all modified / existing stats JSON files.Zod Validation Schemas (
packages/stats-generator/src/schemas.ts):StarterCIStatsSchemaandAppCIStatsSchemato enforce presence and validity of required stats properties (install times, build times, output size, module sizes, dependency counts, and benchmark measurements).JSON Stats Validator (
packages/stats-generator/src/validate-json-stats.ts):validate:jsonscript inpackages/stats-generator/package.json.Unit Tests:
packages/stats-generator/src/validate-json-stats.test.tsto test schema verification for starter and app payloads.