DistributionSetTypeElement#smType now Lazy - loaded only on demand - #3291
Merged
avgustinmm merged 2 commits intoAug 14, 2026
Merged
Conversation
vasilchev
commented
Aug 13, 2026
Contributor
- exposed getSmTypeId to read the smtype id directly from the CompositeKey rather then loading the smType
- exposed JpaDistribtuionSetType getMandatoryModuleTypeIds() and getOptionalModuleTypeIds() again to get the ids from the element composite key rather then loading the sm types
- Improved the QueryUtil for sql readings among tests
- used QueryUtil to test the smType lazy loading (and actually not loading whenever ids are needed)
- exposed getSmTypeId to read the smtype id directly from the CompositeKey rather then loading the smType - exposed JpaDistribtuionSetType getMandatoryModuleTypeIds() and getOptionalModuleTypeIds() again to get the ids from the element composite key rather then loading the sm types - Improved the QueryUtil for sql readings among tests - used QueryUtil to test the smType lazy loading (and actually not loading whenever ids are needed)
avgustinmm
reviewed
Aug 14, 2026
- QueryUtil-> QueryCount - rem,oved redundant default methods from DsType
avgustinmm
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.