Add required OSGi capability to wire o.e.swt to its native fragments - #3561
Add required OSGi capability to wire o.e.swt to its native fragments#3561HannesWell wants to merge 1 commit into
Conversation
This ensures that the org.eclipse.swt bundle can only resolve if a the native fragment of the current platform is available in the OSGi runtime. This also has the effect that for launches, where dependencies are added automatically, the native fragment of the current platform is always added without anything external that enforces its presence (like a feature). Consequently this also allows to remove the p2 instructions doing the same at p2 level. Fixes eclipse-platform#490
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Test Results196 files - 16 196 suites - 16 19s ⏱️ - 26m 4s For more details on these errors, see this check. Results for commit 7b06197. ± Comparison against base commit 38d2d76. This pull request removes 4629 tests. |
From maven point of view one could use a property but this does not work well for IDE... in general it would be good if we could maybe have some kind of general placeholder (like |
This ensures that the org.eclipse.swt bundle can only resolve if a the native fragment of the current platform is available in the OSGi runtime. This also has the effect that for launches, where dependencies are added automatically, the native fragment of the current platform is always added without anything external that enforces its presence (like a feature).
Consequently this also allows to remove the p2 instructions doing the same at p2 level.
Fixes #490
This becomes possible by leveraging
to break the dependency cycle between the o.e.swt host bundle and it's native fragments during the reactor resolution at build time.
This is currently a draft since, we should introduce some mechanism to ensure the capability/requirement versions stay in sync with the
o.e.swthost bundle version.Probably we can do something similar to the javadoc-basher.